Bind a jsdoc enum as SymbolFlags.TypeAlias and not SymbolFlags.Enum #32520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Jul 26, 2019
| @@ -97,7 +97,7 @@ class TypeWriterWalker { | |||
| if (!isSymbolWalk) { | |||
| // Don't try to get the type of something that's already a type. | |||
| // Exception for `T` in `type T = something` because that may evaluate to some interesting type. | |||
| if (ts.isPartOfTypeNode(node) || ts.isIdentifier(node) && !(ts.getMeaningFromDeclaration(node.parent) & ts.SemanticMeaning.Value) && !(ts.isTypeAlias(node.parent) && node.parent.name === node)) { | |||
| if (ts.isPartOfTypeNode(node) || ts.isIdentifier(node) && !(ts.getMeaningFromDeclaration(node.parent) & ts.SemanticMeaning.Value) && !(ts.isTypeAliasDeclaration(node.parent) && node.parent.name === node)) { | |||
There was a problem hiding this comment.
Let me see if I can summarise what this means: we now bail for @callback, @typedef and @enum and some (which?) type aliases. Before it looks like there was a check that @callback and @typedef would usually fail, but sometimes incorrectly pass. But I'm not sure in what circumstances.
There was a problem hiding this comment.
getMeaningFromDeclaration on a JSDoc (as is the parent of all of these) isn't handled afaik, so those cases are already unreachable, as it's defaulted to All.
This was referenced Jul 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32413