Fix infinite constraints #26558
Merged
Fix infinite constraints #26558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test this, thanks (just to check that 50 is sufficient for all our real world code) |
|
Heya @weswigham, I've started to run the extended test suite on this PR at a15fecd. You can monitor the build here. It should now contribute to this PR's status checks. |
weswigham
approved these changes
Aug 20, 2018
RyanCavanaugh
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces recursion depth limiters in
instantiateTypeandgetImmediateBaseConstraintto stop infinite recursion caused by certain patterns of mapped types and index access types in constraints. The PR also removes a similar check fromgetTypeOfInstantiatedSymbolthat was rendered unnecessary by other fixes (no baseline changes result from removing this check and the original repro is now reported as a circularity error).The PR additionally modifies
getConstraintOfDistributiveConditionalTypeto only obtain the constraint of the given type when simplification yields the same type (i.e. when simplification isn't possible).Fixes #22950.
Fixes #26448.