add lib.es2018.intl + fix lib.es2017.intl #23785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Apr 30, 2018
| /// <reference no-default-lib="true"/> | ||
|
|
||
|
|
||
| /// <reference path="lib.es2017.d.ts" /> |
Contributor
There was a problem hiding this comment.
do not update the lib files. they are generated as part of the build (jake LKG) and should not be edited manually.
Contributor
There was a problem hiding this comment.
that applies to all files lib\*
Contributor
Author
There was a problem hiding this comment.
Aha.. That makes sense.
I had a feeling that was the case when editing the file.. 80,000+ lines!
Would you like me to revert these?
Contributor
|
thanks! wanna send a PR to update the docs as well at https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Compiler%20Options.md |
Contributor
Author
|
@mhegazy Sure! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the two separate issues discuessed in #23691. Namely:
Intl.PluralRules.DateTimeFormatwere incorrectly associated with the global namespace, rather than in theIntlnamespace.I'd appreciate a code review on this if at all possible. Most of the changes made were based off of #15369, so there is a chance that I may have edited one or two things incorrectly.
Once the changes are found to be correct, if you could please let me know if/where you'd like tests placed for this, I'll go ahead and add those.
Thanks so much!
cc: @mhegazy
Fixes #23691