Convert 'installTypesForPackge' refactor to a suggestion #22267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
changed the title
mhegazy
reviewed
Mar 1, 2018
src/compiler/program.ts
Outdated
| } | ||
| } | ||
|
|
||
| export function willAllowImplicitAnyJsModule(options: CompilerOptions): boolean { |
There was a problem hiding this comment.
consider moving this to untilities next to getAllowSyntheticDefaultImports and getStricitOptionValue
mhegazy
reviewed
Mar 1, 2018
src/compiler/program.ts
Outdated
| return options.allowJs || !getStrictOptionValue(options, "noImplicitAny"); | ||
| } | ||
|
|
||
| export function createDiagnosticForModuleMissingTypes(errorNode: Node, { packageId, resolvedFileName }: ResolvedModuleFull, moduleReference: string, diag: DiagnosticMessage): Diagnostic { |
There was a problem hiding this comment.
and here too /* @internal */
There was a problem hiding this comment.
consider moving them to utilities
mhegazy
reviewed
Mar 1, 2018
src/compiler/diagnosticMessages.json
Outdated
| @@ -3818,6 +3818,10 @@ | |||
| "category": "Suggestion", | |||
| "code": 80001 | |||
| }, | |||
| "Did not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type.": { | |||
There was a problem hiding this comment.
we probably should take your suggestion of converting an error diagnostic to a suggestion diagnostic.
mhegazy
reviewed
Mar 1, 2018
src/compiler/program.ts
Outdated
| @@ -2416,10 +2416,26 @@ namespace ts { | |||
| return options.jsx ? undefined : Diagnostics.Module_0_was_resolved_to_1_but_jsx_is_not_set; | |||
| } | |||
| function needAllowJs() { | |||
| return options.allowJs || !getStrictOptionValue(options, "noImplicitAny") ? undefined : Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type; | |||
| return willAllowImplicitAnyJsModule(options) ? undefined : Diagnostics.Could_not_find_a_declaration_file_for_module_0_1_implicitly_has_an_any_type; | |||
There was a problem hiding this comment.
why do not we instead log the diagnostic in a different list, a suggestions list. the command line compiler will never report them, but we can query them in the services and add additional messages there as well..
…ing work in calculateSuggestionDiagnostics
mhegazy
approved these changes
Mar 1, 2018
added 2 commits
March 1, 2018 13:02
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19130, had to add duplicate code fix and refactor -- now it's just a code fix and we give a suggestion instead of error diagnostic if
--noImplicitAnyisn't enabled.Note that I had to make a separate diagnostic for the suggestion; this is because each diagnostic is hard-coded with its category. It seems like we could base that on where the diagnostic is coming from instead? Something coming from the parser/checker is an error, something coming from
computeSuggestionDiagnosticsis a suggestion. This will be a bigger problem when I add suggestion diagnostics for unused variables, since we have a lot of different diagnostics for those.