-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Contextually type parameters in super calls using type arguments on the base class. #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, the word you want is "instantiated" rather than "fixed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't write it, but I'll consider fixing it.
|
👍 |
src/compiler/checker.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
lgtm |
Contextually type parameters in super calls using type arguments on the base class.
Seems like we might not even have been performing overload resolution correctly here.
Fixes #1480.