Fix Symbol.valueOf method signature #13553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falsandtru
force-pushed
the
lib.d.ts/symbol
branch
from
f6bc640 to
a925a03
Compare
mhegazy
suggested changes
Jan 23, 2017
| @@ -5556,7 +5556,7 @@ interface Symbol { | |||
| toString(): string; | |||
|
|
|||
| /** Returns the primitive value of the specified object. */ | |||
| valueOf(): Object; | |||
There was a problem hiding this comment.
can you revert these changes. all you need is the change to src/lib/es2015.symbol.d.ts.
There was a problem hiding this comment.
These files are generated from the build, and are not edited manually.
falsandtru
force-pushed
the
lib.d.ts/symbol
branch
from
a925a03 to
da05ced
Compare
|
done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13552