More precise Object.entries type declarations#12207
Merged
mhegazy merged 1 commit intomicrosoft:masterfrom Nov 14, 2016
Merged
Conversation
We can leverage the new index type queries and indexed access types from microsoft#11929 to get better type inference for Object.entries.
|
Hi @ethanresnick, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
mhegazy
approved these changes
Nov 14, 2016
Contributor
|
since you made that change, |
ethanresnick
added a commit
to ethanresnick/TypeScript
that referenced
this pull request
Nov 15, 2016
Applying the same logic used on Object.entries in the prior commit and in microsoft#12207
ethanresnick
added a commit
to ethanresnick/TypeScript
that referenced
this pull request
Nov 15, 2016
Applying the same logic used on Object.entries in the prior commit and in microsoft#12207
mhegazy
added a commit
that referenced
this pull request
Nov 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new index type queries and indexed access types from #11929 to get better type inference for Object.entries.
Before:
After:
One edge case is
Object.entries({}). Before, that was inferred as[string, {}][]; with this change it'd be[never, any][]. That might be a problem, although I don't think it is, since never is assignable to string.