Skip to content

Commit ecd15e5

Browse files
committed
Symbol order doesn’t matter here
1 parent f276466 commit ecd15e5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/services/completions.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,7 +1310,7 @@ namespace ts.Completions {
13101310
/** Bucket B */
13111311
const aliasesToAlreadyIncludedSymbols = createMap<true>();
13121312
/** Bucket C */
1313-
const aliasesToReturnIfOriginalsAreMissing = createMap<{ alias: Symbol, moduleSymbol: Symbol, insertAt: number }>();
1313+
const aliasesToReturnIfOriginalsAreMissing = createMap<{ alias: Symbol, moduleSymbol: Symbol }>();
13141314

13151315
codefix.forEachExternalModuleToImportFrom(typeChecker, host, preferences, program.redirectTargetsMap, sourceFile, program.getSourceFiles(), moduleSymbol => {
13161316
// Perf -- ignore other modules if this is a request for details
@@ -1348,7 +1348,7 @@ namespace ts.Completions {
13481348
const nearestExportSymbolId = getSymbolId(Debug.assertDefined(getNearestExportSymbol(symbol)));
13491349
const symbolHasBeenSeen = !!symbolToOriginInfoMap[nearestExportSymbolId] || aliasesToAlreadyIncludedSymbols.has(nearestExportSymbolId.toString());
13501350
if (!symbolHasBeenSeen) {
1351-
aliasesToReturnIfOriginalsAreMissing.set(nearestExportSymbolId.toString(), { alias: symbol, moduleSymbol, insertAt: symbols.length });
1351+
aliasesToReturnIfOriginalsAreMissing.set(nearestExportSymbolId.toString(), { alias: symbol, moduleSymbol });
13521352
aliasesToAlreadyIncludedSymbols.set(getSymbolId(symbol).toString(), true);
13531353
}
13541354
else {
@@ -1367,16 +1367,16 @@ namespace ts.Completions {
13671367

13681368
// By this point, any potential duplicates that were actually duplicates have been
13691369
// removed, so the rest need to be added. (Step 4 in diagrammed example)
1370-
aliasesToReturnIfOriginalsAreMissing.forEach(({ alias, moduleSymbol, insertAt }) => pushSymbol(alias, moduleSymbol, insertAt));
1370+
aliasesToReturnIfOriginalsAreMissing.forEach(({ alias, moduleSymbol }) => pushSymbol(alias, moduleSymbol));
13711371

1372-
function pushSymbol(symbol: Symbol, moduleSymbol: Symbol, insertAt = symbols.length) {
1372+
function pushSymbol(symbol: Symbol, moduleSymbol: Symbol) {
13731373
const isDefaultExport = symbol.escapedName === InternalSymbolName.Default;
13741374
if (isDefaultExport) {
13751375
symbol = getLocalSymbolForExportDefault(symbol) || symbol;
13761376
}
13771377
const origin: SymbolOriginInfoExport = { kind: SymbolOriginInfoKind.Export, moduleSymbol, isDefaultExport };
13781378
if (detailsEntryId || stringContainsCharactersInOrder(getSymbolName(symbol, origin, target).toLowerCase(), tokenTextLowerCase)) {
1379-
symbols.splice(insertAt, 0, symbol);
1379+
symbols.push(symbol);
13801380
symbolToSortTextMap[getSymbolId(symbol)] = SortText.AutoImportSuggestions;
13811381
symbolToOriginInfoMap[getSymbolId(symbol)] = origin;
13821382
}

0 commit comments

Comments
 (0)