Use label details for obj literal method completions

Author: gabritto

src/server/editorServices.ts

@@ -296,7 +296,7 @@ namespace ts.server {
 
     /*@internal*/
     export function convertUserPreferences(preferences: protocol.UserPreferences): UserPreferences {
-        const { lazyConfiguredProjectsFromExternalProject, ...userPreferences } = preferences;
+        const { lazyConfiguredProjectsFromExternalProject, includeCompletionsWithObjectLiteralMethodSnippets: true, ...userPreferences } = preferences;
         return userPreferences;
     }
 

src/services/completions.ts

@@ -699,6 +699,7 @@ namespace ts.Completions {
         let source = getSourceFromOrigin(origin);
         let sourceDisplay;
         let hasAction;
+        let labelDetails;
 
         const typeChecker = program.getTypeChecker();
         const insertQuestionDot = origin && originIsNullableMember(origin);
@@ -778,7 +779,7 @@ namespace ts.Completions {
             if (!entry) {
                 return undefined;
             }
-            ({ insertText, isSnippet, importAdder, sourceDisplay } = entry);
+            ({ insertText, isSnippet, importAdder, labelDetails } = entry);
             source = CompletionSource.ObjectLiteralMethodSnippet;
             sortText = SortText.SortBelow(sortText);
             if (importAdder.hasFixes()) {
@@ -840,6 +841,7 @@ namespace ts.Completions {
             insertText,
             replacementSpan,
             sourceDisplay,
+            labelDetails,
             isSnippet,
             isPackageJsonImport: originIsPackageJsonImport(origin) || undefined,
             isImportStatementCompletion: !!importCompletionNode || undefined,
@@ -1064,7 +1066,7 @@ namespace ts.Completions {
         options: CompilerOptions,
         preferences: UserPreferences,
         formatContext: formatting.FormatContext | undefined,
-    ): { insertText: string, isSnippet?: true, importAdder: codefix.ImportAdder, sourceDisplay: SymbolDisplayPart[] } | undefined {
+    ): { insertText: string, isSnippet?: true, importAdder: codefix.ImportAdder, labelDetails: CompletionEntryLabelDetails } | undefined {
         let isSnippet: true | undefined;
         let insertText: string = name;
 
@@ -1101,16 +1103,22 @@ namespace ts.Completions {
             insertText = printer.printSnippetList(ListFormat.CommaDelimited | ListFormat.AllowTrailingComma, factory.createNodeArray([method], /*hasTrailingComma*/ true), sourceFile);
         }
 
+        const signaturePrinter = createPrinter({
+            removeComments: true,
+            module: options.module,
+            target: options.target,
+            omitTrailingSemicolon: true,
+        });
         const methodSignature = factory.createMethodSignature(
             method.modifiers,
-            method.name,
+            /*name*/ "",
             method.questionToken,
             method.typeParameters,
             method.parameters,
             method.type);
-        const sourceDisplay = nodeToDisplayParts(methodSignature, enclosingDeclaration);
+        const labelDetails = { detail: signaturePrinter.printNode(EmitHint.Unspecified, methodSignature, sourceFile) };
 
-        return { isSnippet, insertText, importAdder, sourceDisplay };
+        return { isSnippet, insertText, importAdder, labelDetails };
 
     };