Skip to content

Commit e50e01f

Browse files
committed
Revert "Bind typedef/enum on all assignment decl kinds (#33240)"
This reverts commit b542bdf.
1 parent b3ec4ed commit e50e01f

File tree

7 files changed

+1
-84
lines changed

7 files changed

+1
-84
lines changed

src/compiler/binder.ts

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1827,23 +1827,7 @@ namespace ts {
18271827
bindPotentiallyMissingNamespaces(file.symbol, declName.parent, isTopLevel,
18281828
!!findAncestor(declName, d => isPropertyAccessExpression(d) && d.name.escapedText === "prototype"), /*containerIsClass*/ false);
18291829
const oldContainer = container;
1830-
switch (getAssignmentDeclarationPropertyAccessKind(declName.parent)) {
1831-
case AssignmentDeclarationKind.ExportsProperty:
1832-
case AssignmentDeclarationKind.ModuleExports:
1833-
container = file;
1834-
break;
1835-
case AssignmentDeclarationKind.ThisProperty:
1836-
container = declName.parent.expression;
1837-
break;
1838-
case AssignmentDeclarationKind.PrototypeProperty:
1839-
container = (declName.parent.expression as PropertyAccessExpression).name;
1840-
break;
1841-
case AssignmentDeclarationKind.Property:
1842-
container = isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name : declName.parent.expression;
1843-
break;
1844-
case AssignmentDeclarationKind.None:
1845-
return Debug.fail("Shouldn't have detected typedef or enum on non-assignment declaration");
1846-
}
1830+
container = isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name : declName.parent.expression;
18471831
declareModuleMember(typeAlias, SymbolFlags.TypeAlias, SymbolFlags.TypeAliasExcludes);
18481832
container = oldContainer;
18491833
}

tests/baselines/reference/enumTagOnExports.symbols

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/baselines/reference/enumTagOnExports.types

Lines changed: 0 additions & 19 deletions
This file was deleted.

tests/baselines/reference/enumTagOnExports2.symbols

Lines changed: 0 additions & 7 deletions
This file was deleted.

tests/baselines/reference/enumTagOnExports2.types

Lines changed: 0 additions & 9 deletions
This file was deleted.

tests/cases/conformance/jsdoc/enumTagOnExports.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/cases/conformance/jsdoc/enumTagOnExports2.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)