fix: apply completions for unclosed literal and missing comma

Author: orange4glace

src/services/completions.ts

@@ -1895,7 +1895,7 @@ namespace ts.Completions {
 
                 // Check completions for Object property value shorthand
                 if (instantiatedType === undefined) {
-                    if (objectLikeContainer.flags & (NodeFlags.ThisNodeHasError | NodeFlags.InWithStatement)) {
+                    if (objectLikeContainer.flags & NodeFlags.InWithStatement) {
                         return GlobalsSearch.Fail;
                     }
                     return GlobalsSearch.Continue;
@@ -2326,6 +2326,7 @@ namespace ts.Completions {
             }
 
             return isDeclarationName(contextToken)
+                && !isShorthandPropertyAssignment(contextToken.parent)
                 && !isJsxAttribute(contextToken.parent)
                 // Don't block completions if we're in `class C /**/`, because we're *past* the end of the identifier and might want to complete `extends`.
                 // If `contextToken !== previousToken`, this is `class C ex/**/`.

tests/cases/fourslash/completionPropertyShorthandForObjectLiteral2.ts

@@ -0,0 +1,17 @@
+/// <reference path="fourslash.ts"/>
+
+//// const foo = 1;
+//// const bar = 2;
+
+//// const obj1 = {
+////   foo b/*1*/
+//// };
+
+//// const obj2: any = {
+////   foo b/*2*/
+//// };
+
+verify.completions({
+    marker: test.markers(),
+    includes: ["bar"]
+});

tests/cases/fourslash/completionPropertyShorthandForObjectLiteral3.ts

@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts"/>
+
+//// const foo = 1;
+//// const bar = 2;
+//// const obj = {
+////   foo b/*1*/
+
+verify.completions({
+    marker: ["1"],
+    includes: ["bar"]
+});

tests/cases/fourslash/completionPropertyShorthandForObjectLiteral4.ts

@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts"/>
+
+//// const foo = 1;
+//// const bar = 2;
+//// const obj: any = {
+////   foo b/*1*/
+
+verify.completions({
+    marker: ["1"],
+    includes: ["bar"]
+});

tests/cases/fourslash/globalCompletionListInsideObjectLiterals.ts

@@ -28,7 +28,6 @@
 // 5, 6: Literal member completion after member name with empty member expression.
 const exact = ["p1", "p2", "p3", "p4", ...completion.globalsPlus(["ObjectLiterals"])];
 verify.completions(
-    { marker: ["1"], exact, isNewIdentifierLocation: true },
-    { marker: ["2", "3", "5", "6"], exact },
-    { marker: "4", exact: undefined },
+    { marker: ["1",], exact, isNewIdentifierLocation: true },
+    { marker: ["2", "3", "4", "5", "6"], exact }
 );