Merge pull request #15013 from aozgaa/tripleEquals

aozgaa · web-flow · commit b038d28ed449 · 2017-04-17T17:08:34.000-07:00
enforce triple-equals
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -349,7 +349,7 @@ namespace ts {
             TypeofNEHostObject = 1 << 13, // typeof x !== "xxx"
             EQUndefined = 1 << 14,        // x === undefined
             EQNull = 1 << 15,             // x === null
-            EQUndefinedOrNull = 1 << 16,  // x == undefined / x == null
+            EQUndefinedOrNull = 1 << 16,  // x === undefined / x === null
             NEUndefined = 1 << 17,        // x !== undefined
             NENull = 1 << 18,             // x !== null
             NEUndefinedOrNull = 1 << 19,  // x != undefined / x != null
@@ -17616,7 +17616,7 @@ namespace ts {
         function checkObjectTypeForDuplicateDeclarations(node: TypeLiteralNode | InterfaceDeclaration) {
             const names = createMap<boolean>();
             for (const member of node.members) {
-                if (member.kind == SyntaxKind.PropertySignature) {
+                if (member.kind === SyntaxKind.PropertySignature) {
                     let memberName: string;
                     switch (member.name.kind) {
                         case SyntaxKind.StringLiteral:
diff --git a/src/compiler/moduleNameResolver.ts b/src/compiler/moduleNameResolver.ts
@@ -378,7 +378,7 @@ namespace ts {
                     directoryPathMap.set(parent, result);
                     current = parent;
 
-                    if (current == commonPrefix) {
+                    if (current === commonPrefix) {
                         break;
                     }
                 }
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -557,7 +557,7 @@ namespace ts {
             // combine results of resolutions and predicted results
             let j = 0;
             for (let i = 0; i < result.length; i++) {
-                if (result[i] == predictedToResolveToAmbientModuleMarker) {
+                if (result[i] === predictedToResolveToAmbientModuleMarker) {
                     result[i] = undefined;
                 }
                 else {
@@ -1364,7 +1364,7 @@ namespace ts {
 
                 // If the file was previously found via a node_modules search, but is now being processed as a root file,
                 // then everything it sucks in may also be marked incorrectly, and needs to be checked again.
-                if (file && sourceFilesFoundSearchingNodeModules.get(file.path) && currentNodeModulesDepth == 0) {
+                if (file && sourceFilesFoundSearchingNodeModules.get(file.path) && currentNodeModulesDepth === 0) {
                     sourceFilesFoundSearchingNodeModules.set(file.path, false);
                     if (!options.noResolve) {
                         processReferencedFiles(file, isDefaultLib);
diff --git a/src/compiler/tsc.ts b/src/compiler/tsc.ts
@@ -30,7 +30,7 @@ namespace ts {
     }
 
     function reportEmittedFiles(files: string[]): void {
-        if (!files || files.length == 0) {
+        if (!files || files.length === 0) {
             return;
         }
 
@@ -282,7 +282,7 @@ namespace ts {
                     // When the configFileName is just "tsconfig.json", the watched directory should be
                     // the current directory; if there is a given "project" parameter, then the configFileName
                     // is an absolute file name.
-                    directory == "" ? "." : directory,
+                    directory === "" ? "." : directory,
                     watchedDirectoryChanged, /*recursive*/ true);
             }
         }
@@ -334,7 +334,7 @@ namespace ts {
                         // When the configFileName is just "tsconfig.json", the watched directory should be
                         // the current directory; if there is a given "project" parameter, then the configFileName
                         // is an absolute file name.
-                        directory == "" ? "." : directory,
+                        directory === "" ? "." : directory,
                         watchedDirectoryChanged, /*recursive*/ true);
                 }
             }
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4428,7 +4428,7 @@ namespace ts {
             newEndN = Math.max(newEnd2, newEnd2 + (newEnd1 - oldEnd2));
         }
 
-        return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength:*/ newEndN - oldStartN);
+        return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength*/ newEndN - oldStartN);
     }
 
     export function getTypeParameterOwner(d: Declaration): Declaration {
@@ -4604,7 +4604,7 @@ namespace ts {
      */
     export function getParseTreeNode<T extends Node>(node: Node, nodeTest?: (node: Node) => node is T): T;
     export function getParseTreeNode(node: Node, nodeTest?: (node: Node) => boolean): Node {
-        if (node == undefined || isParseTreeNode(node)) {
+        if (node === undefined || isParseTreeNode(node)) {
             return node;
         }
 
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -2367,13 +2367,13 @@ namespace FourSlash {
 
         public verifyImportFixAtPosition(expectedTextArray: string[], errorCode?: number) {
             const ranges = this.getRanges();
-            if (ranges.length == 0) {
+            if (ranges.length === 0) {
                 this.raiseError("At least one range should be specified in the testfile.");
             }
 
             const codeFixes = this.getCodeFixActions(this.activeFile.fileName, errorCode);
 
-            if (!codeFixes || codeFixes.length == 0) {
+            if (!codeFixes || codeFixes.length === 0) {
                 this.raiseError("No codefixes returned.");
             }
 
@@ -2738,7 +2738,7 @@ namespace FourSlash {
         private assertItemInCompletionList(items: ts.CompletionEntry[], name: string, text?: string, documentation?: string, kind?: string, spanIndex?: number) {
             for (const item of items) {
                 if (item.name === name) {
-                    if (documentation != undefined || text !== undefined) {
+                    if (documentation !== undefined || text !== undefined) {
                         const details = this.getCompletionEntryDetails(item.name);
 
                         if (documentation !== undefined) {
@@ -2989,9 +2989,8 @@ ${code}
                         }
                     }
                 }
-                // TODO: should be '==='?
             }
-            else if (line == "" || lineLength === 0) {
+            else if (line === "" || lineLength === 0) {
                 // Previously blank lines between fourslash content caused it to be considered as 2 files,
                 // Remove this behavior since it just causes errors now
             }
diff --git a/src/harness/harness.ts b/src/harness/harness.ts
@@ -1933,7 +1933,7 @@ namespace Harness {
                 }
 
                 const parentDirectory = IO.directoryName(dirName);
-                if (parentDirectory != "") {
+                if (parentDirectory !== "") {
                     createDirectoryStructure(parentDirectory);
                 }
                 IO.createDirectory(dirName);
diff --git a/src/harness/projectsRunner.ts b/src/harness/projectsRunner.ts
@@ -111,8 +111,7 @@ class ProjectRunner extends RunnerBase {
                 else if (url.indexOf(diskProjectPath) === 0) {
                     // Replace the disk specific path into the project root path
                     url = url.substr(diskProjectPath.length);
-                    // TODO: should be '!=='?
-                    if (url.charCodeAt(0) != ts.CharacterCodes.slash) {
+                    if (url.charCodeAt(0) !== ts.CharacterCodes.slash) {
                         url = "/" + url;
                     }
                 }
diff --git a/src/harness/sourceMapRecorder.ts b/src/harness/sourceMapRecorder.ts
@@ -50,11 +50,11 @@ namespace Harness.SourceMapRecorder {
                 return true;
             }
 
-            if (sourceMapMappings.charAt(decodingIndex) == ",") {
+            if (sourceMapMappings.charAt(decodingIndex) === ",") {
                 return true;
             }
 
-            if (sourceMapMappings.charAt(decodingIndex) == ";") {
+            if (sourceMapMappings.charAt(decodingIndex) === ";") {
                 return true;
             }
 
@@ -117,15 +117,15 @@ namespace Harness.SourceMapRecorder {
             }
 
             while (decodingIndex < sourceMapMappings.length) {
-                if (sourceMapMappings.charAt(decodingIndex) == ";") {
+                if (sourceMapMappings.charAt(decodingIndex) === ";") {
                     // New line
                     decodeOfEncodedMapping.emittedLine++;
                     decodeOfEncodedMapping.emittedColumn = 1;
                     decodingIndex++;
                     continue;
                 }
 
-                if (sourceMapMappings.charAt(decodingIndex) == ",") {
+                if (sourceMapMappings.charAt(decodingIndex) === ",") {
                     // Next entry is on same line - no action needed
                     decodingIndex++;
                     continue;
diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts
@@ -3228,7 +3228,7 @@ namespace ts.projectSystem {
             checkNumberOfInferredProjects(projectService, 1);
 
             const configuredProject = projectService.configuredProjects[0];
-            assert.isTrue(configuredProject.getFileNames().length == 0);
+            assert.isTrue(configuredProject.getFileNames().length === 0);
 
             const inferredProject = projectService.inferredProjects[0];
             assert.isTrue(inferredProject.containsFile(<server.NormalizedPath>file1.path));
diff --git a/src/harness/unittests/versionCache.ts b/src/harness/unittests/versionCache.ts
@@ -278,7 +278,7 @@ and grew 1cm per day`;
                 const insertString = testContent.substring(rsa[i], rsa[i] + las[i]);
                 svc.edit(ersa[i], elas[i], insertString);
                 checkText = editFlat(ersa[i], elas[i], insertString, checkText);
-                if (0 == (i % 4)) {
+                if (0 === (i % 4)) {
                     const snap = svc.getSnapshot();
                     const snapText = snap.getText(0, checkText.length);
                     assert.equal(checkText, snapText);
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -257,7 +257,7 @@ namespace ts.server {
         startWatchingContainingDirectoriesForFile(fileName: string, project: InferredProject, callback: (fileName: string) => void) {
             let currentPath = getDirectoryPath(fileName);
             let parentPath = getDirectoryPath(currentPath);
-            while (currentPath != parentPath) {
+            while (currentPath !== parentPath) {
                 if (!this.directoryWatchersForTsconfig.has(currentPath)) {
                     this.projectService.logger.info(`Add watcher for: ${currentPath}`);
                     this.directoryWatchersForTsconfig.set(currentPath, this.projectService.host.watchDirectory(currentPath, callback));
@@ -618,7 +618,7 @@ namespace ts.server {
          */
         private onConfigFileAddedForInferredProject(fileName: string) {
             // TODO: check directory separators
-            if (getBaseFileName(fileName) != "tsconfig.json") {
+            if (getBaseFileName(fileName) !== "tsconfig.json") {
                 this.logger.info(`${fileName} is not tsconfig.json`);
                 return;
             }
@@ -1033,7 +1033,7 @@ namespace ts.server {
                 const scriptKind = propertyReader.getScriptKind(f);
                 const hasMixedContent = propertyReader.hasMixedContent(f, this.hostConfiguration.extraFileExtensions);
                 if (this.host.fileExists(rootFilename)) {
-                    const info = this.getOrCreateScriptInfoForNormalizedPath(toNormalizedPath(rootFilename), /*openedByClient*/ clientFileName == rootFilename, /*fileContent*/ undefined, scriptKind, hasMixedContent);
+                    const info = this.getOrCreateScriptInfoForNormalizedPath(toNormalizedPath(rootFilename), /*openedByClient*/ clientFileName === rootFilename, /*fileContent*/ undefined, scriptKind, hasMixedContent);
                     project.addRoot(info);
                 }
                 else {
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -643,7 +643,7 @@ namespace ts.server {
             // check if requested version is the same that we have reported last time
             if (this.lastReportedFileNames && lastKnownVersion === this.lastReportedVersion) {
                 // if current structure version is the same - return info without any changes
-                if (this.projectStructureVersion == this.lastReportedVersion && !updatedFileNames) {
+                if (this.projectStructureVersion === this.lastReportedVersion && !updatedFileNames) {
                     return { info, projectErrors: this.projectErrors };
                 }
                 // compute and return the difference
diff --git a/src/server/scriptVersionCache.ts b/src/server/scriptVersionCache.ts
@@ -79,7 +79,7 @@ namespace ts.server {
             const lm = LineIndex.linesFromText(insertedText);
             const lines = lm.lines;
             if (lines.length > 1) {
-                if (lines[lines.length - 1] == "") {
+                if (lines[lines.length - 1] === "") {
                     lines.length--;
                 }
             }
@@ -570,7 +570,7 @@ namespace ts.server {
                 }
                 if (this.checkEdits) {
                     const updatedText = this.getText(0, this.root.charCount());
-                    Debug.assert(checkText == updatedText, "buffer edit mismatch");
+                    Debug.assert(checkText === updatedText, "buffer edit mismatch");
                 }
                 return walker.lineIndex;
             }
diff --git a/src/server/server.ts b/src/server/server.ts
@@ -380,7 +380,7 @@ namespace ts.server {
             }
 
             this.projectService.updateTypingsForProject(response);
-            if (response.kind == ActionSet && this.socket) {
+            if (response.kind === ActionSet && this.socket) {
                 this.sendEvent(0, "setTypings", response);
             }
         }
diff --git a/src/server/session.ts b/src/server/session.ts
@@ -49,7 +49,7 @@ namespace ts.server {
         if (a.file < b.file) {
             return -1;
         }
-        else if (a.file == b.file) {
+        else if (a.file === b.file) {
             const n = compareNumber(a.start.line, b.start.line);
             if (n === 0) {
                 return compareNumber(a.start.offset, b.start.offset);
@@ -1128,7 +1128,7 @@ namespace ts.server {
             // getFormattingEditsAfterKeystroke either empty or pertaining
             // only to the previous line.  If all this is true, then
             // add edits necessary to properly indent the current line.
-            if ((args.key == "\n") && ((!edits) || (edits.length === 0) || allEditsBeforePos(edits, position))) {
+            if ((args.key === "\n") && ((!edits) || (edits.length === 0) || allEditsBeforePos(edits, position))) {
                 const lineInfo = scriptInfo.getLineInfo(args.line);
                 if (lineInfo && (lineInfo.leaf) && (lineInfo.leaf.text)) {
                     const lineText = lineInfo.leaf.text;
@@ -1137,10 +1137,10 @@ namespace ts.server {
                         let hasIndent = 0;
                         let i: number, len: number;
                         for (i = 0, len = lineText.length; i < len; i++) {
-                            if (lineText.charAt(i) == " ") {
+                            if (lineText.charAt(i) === " ") {
                                 hasIndent++;
                             }
-                            else if (lineText.charAt(i) == "\t") {
+                            else if (lineText.charAt(i) === "\t") {
                                 hasIndent += formatOptions.tabSize;
                             }
                             else {
@@ -1543,7 +1543,7 @@ namespace ts.server {
             const normalizedFileName = toNormalizedPath(fileName);
             const project = this.projectService.getDefaultProjectForFile(normalizedFileName, /*refreshInferredProjects*/ true);
             for (const fileNameInProject of fileNamesInProject) {
-                if (this.getCanonicalFileName(fileNameInProject) == this.getCanonicalFileName(fileName))
+                if (this.getCanonicalFileName(fileNameInProject) === this.getCanonicalFileName(fileName))
                     highPriorityFiles.push(fileNameInProject);
                 else {
                     const info = this.projectService.getScriptInfo(fileNameInProject);
@@ -1564,7 +1564,7 @@ namespace ts.server {
                 const checkList = fileNamesInProject.map(fileName => ({ fileName, project }));
                 // Project level error analysis runs on background files too, therefore
                 // doesn't require the file to be opened
-                this.updateErrorCheck(next, checkList, this.changeSeq, (n) => n == this.changeSeq, delay, 200, /*requireOpen*/ false);
+                this.updateErrorCheck(next, checkList, this.changeSeq, (n) => n === this.changeSeq, delay, 200, /*requireOpen*/ false);
             }
         }
 
diff --git a/src/server/typingsCache.ts b/src/server/typingsCache.ts
@@ -61,7 +61,7 @@ namespace ts.server {
 
     function compilerOptionsChanged(opt1: CompilerOptions, opt2: CompilerOptions): boolean {
         // TODO: add more relevant properties
-        return opt1.allowJs != opt2.allowJs;
+        return opt1.allowJs !== opt2.allowJs;
     }
 
     function unresolvedImportsChanged(imports1: SortedReadonlyArray<string>, imports2: SortedReadonlyArray<string>): boolean {
diff --git a/src/server/typingsInstaller/nodeTypingsInstaller.ts b/src/server/typingsInstaller/nodeTypingsInstaller.ts
@@ -31,7 +31,7 @@ namespace ts.server.typingsInstaller {
     }
 
     function getNPMLocation(processName: string) {
-        if (path.basename(processName).indexOf("node") == 0) {
+        if (path.basename(processName).indexOf("node") === 0) {
             return `"${path.join(path.dirname(process.argv[0]), "npm")}"`;
         }
         else {
diff --git a/src/server/utilities.ts b/src/server/utilities.ts
@@ -219,7 +219,7 @@ namespace ts.server {
         }
 
         public scheduleCollect() {
-            if (!this.host.gc || this.timerId != undefined) {
+            if (!this.host.gc || this.timerId !== undefined) {
                 // no global.gc or collection was already scheduled - skip this request
                 return;
             }
diff --git a/src/services/breakpoints.ts b/src/services/breakpoints.ts
@@ -264,7 +264,7 @@ namespace ts.BreakpointResolver {
                         // a or ...c  or d: x from
                         // [a, b, ...c] or { a, b } or { d: x } from destructuring pattern
                         if ((node.kind === SyntaxKind.Identifier ||
-                            node.kind == SyntaxKind.SpreadElement ||
+                            node.kind === SyntaxKind.SpreadElement ||
                             node.kind === SyntaxKind.PropertyAssignment ||
                             node.kind === SyntaxKind.ShorthandPropertyAssignment) &&
                             isArrayLiteralOrObjectLiteralDestructuringPattern(node.parent)) {
diff --git a/src/services/codefixes/fixAddMissingMember.ts b/src/services/codefixes/fixAddMissingMember.ts
@@ -14,7 +14,7 @@ namespace ts.codefix {
         //      ^^^^^^^
         const token = getTokenAtPosition(sourceFile, start);
 
-        if (token.kind != SyntaxKind.Identifier) {
+        if (token.kind !== SyntaxKind.Identifier) {
             return undefined;
         }
 
diff --git a/src/services/codefixes/fixClassSuperMustPrecedeThisAccess.ts b/src/services/codefixes/fixClassSuperMustPrecedeThisAccess.ts
@@ -18,7 +18,7 @@ namespace ts.codefix {
 
             // figure out if the `this` access is actually inside the supercall
             // i.e. super(this.a), since in that case we won't suggest a fix
-            if (superCall.expression && superCall.expression.kind == SyntaxKind.CallExpression) {
+            if (superCall.expression && superCall.expression.kind === SyntaxKind.CallExpression) {
                 const arguments = (<CallExpression>superCall.expression).arguments;
                 for (let i = 0; i < arguments.length; i++) {
                     if ((<PropertyAccessExpression>arguments[i]).expression === token) {
diff --git a/src/services/codefixes/unusedIdentifierFixes.ts b/src/services/codefixes/unusedIdentifierFixes.ts
@@ -125,7 +125,7 @@ namespace ts.codefix {
 
                         case SyntaxKind.NamespaceImport:
                             const namespaceImport = <NamespaceImport>token.parent;
-                            if (namespaceImport.name == token && !(<ImportClause>namespaceImport.parent).name) {
+                            if (namespaceImport.name === token && !(<ImportClause>namespaceImport.parent).name) {
                                 const importDecl = getAncestor(namespaceImport, SyntaxKind.ImportDeclaration);
                                 return deleteNode(importDecl);
                             }
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1311,7 +1311,7 @@ namespace ts.Completions {
     }
 
     function isEqualityOperatorKind(kind: SyntaxKind) {
-        return kind == SyntaxKind.EqualsEqualsToken ||
+        return kind === SyntaxKind.EqualsEqualsToken ||
             kind === SyntaxKind.ExclamationEqualsToken ||
             kind === SyntaxKind.EqualsEqualsEqualsToken ||
             kind === SyntaxKind.ExclamationEqualsEqualsToken;
diff --git a/src/services/shims.ts b/src/services/shims.ts
diff --git a/src/services/signatureHelp.ts b/src/services/signatureHelp.ts
diff --git a/src/services/textChanges.ts b/src/services/textChanges.ts
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
diff --git a/tslint.json b/tslint.json

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ namespace ts {`
`378`	`378`	`directoryPathMap.set(parent, result);`
`379`	`379`	`current = parent;`
`380`	`380`
`381`		`- if (current == commonPrefix) {`
	`381`	`+ if (current === commonPrefix) {`
`382`	`382`	`break;`
`383`	`383`	`}`
`384`	`384`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace ts {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`function reportEmittedFiles(files: string[]): void {`
`33`		`- if (!files \|\| files.length == 0) {`
	`33`	`+ if (!files \|\| files.length === 0) {`
`34`	`34`	`return;`
`35`	`35`	`}`
`36`	`36`
`@@ -282,7 +282,7 @@ namespace ts {`
`282`	`282`	`// When the configFileName is just "tsconfig.json", the watched directory should be`
`283`	`283`	`// the current directory; if there is a given "project" parameter, then the configFileName`
`284`	`284`	`// is an absolute file name.`
`285`		`- directory == "" ? "." : directory,`
	`285`	`+ directory === "" ? "." : directory,`
`286`	`286`	`watchedDirectoryChanged, /recursive/ true);`
`287`	`287`	`}`
`288`	`288`	`}`
`@@ -334,7 +334,7 @@ namespace ts {`
`334`	`334`	`// When the configFileName is just "tsconfig.json", the watched directory should be`
`335`	`335`	`// the current directory; if there is a given "project" parameter, then the configFileName`
`336`	`336`	`// is an absolute file name.`
`337`		`- directory == "" ? "." : directory,`
	`337`	`+ directory === "" ? "." : directory,`
`338`	`338`	`watchedDirectoryChanged, /recursive/ true);`
`339`	`339`	`}`
`340`	`340`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4428,7 +4428,7 @@ namespace ts {`
`4428`	`4428`	`newEndN = Math.max(newEnd2, newEnd2 + (newEnd1 - oldEnd2));`
`4429`	`4429`	`}`
`4430`	`4430`
`4431`		`- return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /newLength:/ newEndN - oldStartN);`
	`4431`	`+ return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /newLength/ newEndN - oldStartN);`
`4432`	`4432`	`}`
`4433`	`4433`
`4434`	`4434`	`export function getTypeParameterOwner(d: Declaration): Declaration {`
`@@ -4604,7 +4604,7 @@ namespace ts {`
`4604`	`4604`	`*/`
`4605`	`4605`	`export function getParseTreeNode<T extends Node>(node: Node, nodeTest?: (node: Node) => node is T): T;`
`4606`	`4606`	`export function getParseTreeNode(node: Node, nodeTest?: (node: Node) => boolean): Node {`
`4607`		`- if (node == undefined \|\| isParseTreeNode(node)) {`
	`4607`	`+ if (node === undefined \|\| isParseTreeNode(node)) {`
`4608`	`4608`	`return node;`
`4609`	`4609`	`}`
`4610`	`4610`
Original file line number	Diff line number	Diff line change
`@@ -2367,13 +2367,13 @@ namespace FourSlash {`
`2367`	`2367`
`2368`	`2368`	`public verifyImportFixAtPosition(expectedTextArray: string[], errorCode?: number) {`
`2369`	`2369`	`const ranges = this.getRanges();`
`2370`		`- if (ranges.length == 0) {`
	`2370`	`+ if (ranges.length === 0) {`
`2371`	`2371`	`this.raiseError("At least one range should be specified in the testfile.");`
`2372`	`2372`	`}`
`2373`	`2373`
`2374`	`2374`	`const codeFixes = this.getCodeFixActions(this.activeFile.fileName, errorCode);`
`2375`	`2375`
`2376`		`- if (!codeFixes \|\| codeFixes.length == 0) {`
	`2376`	`+ if (!codeFixes \|\| codeFixes.length === 0) {`
`2377`	`2377`	`this.raiseError("No codefixes returned.");`
`2378`	`2378`	`}`
`2379`	`2379`
`@@ -2738,7 +2738,7 @@ namespace FourSlash {`
`2738`	`2738`	`private assertItemInCompletionList(items: ts.CompletionEntry[], name: string, text?: string, documentation?: string, kind?: string, spanIndex?: number) {`
`2739`	`2739`	`for (const item of items) {`
`2740`	`2740`	`if (item.name === name) {`
`2741`		`- if (documentation != undefined \|\| text !== undefined) {`
	`2741`	`+ if (documentation !== undefined \|\| text !== undefined) {`
`2742`	`2742`	`const details = this.getCompletionEntryDetails(item.name);`
`2743`	`2743`
`2744`	`2744`	`if (documentation !== undefined) {`
`@@ -2989,9 +2989,8 @@ ${code}`
`2989`	`2989`	`}`
`2990`	`2990`	`}`
`2991`	`2991`	`}`
`2992`		`- // TODO: should be '==='?`
`2993`	`2992`	`}`
`2994`		`- else if (line == "" \|\| lineLength === 0) {`
	`2993`	`+ else if (line === "" \|\| lineLength === 0) {`
`2995`	`2994`	`// Previously blank lines between fourslash content caused it to be considered as 2 files,`
`2996`	`2995`	`// Remove this behavior since it just causes errors now`
`2997`	`2996`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1933,7 +1933,7 @@ namespace Harness {`
`1933`	`1933`	`}`
`1934`	`1934`
`1935`	`1935`	`const parentDirectory = IO.directoryName(dirName);`
`1936`		`- if (parentDirectory != "") {`
	`1936`	`+ if (parentDirectory !== "") {`
`1937`	`1937`	`createDirectoryStructure(parentDirectory);`
`1938`	`1938`	`}`
`1939`	`1939`	`IO.createDirectory(dirName);`
Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,7 @@ class ProjectRunner extends RunnerBase {`
`111`	`111`	`else if (url.indexOf(diskProjectPath) === 0) {`
`112`	`112`	`// Replace the disk specific path into the project root path`
`113`	`113`	`url = url.substr(diskProjectPath.length);`
`114`		`- // TODO: should be '!=='?`
`115`		`- if (url.charCodeAt(0) != ts.CharacterCodes.slash) {`
	`114`	`+ if (url.charCodeAt(0) !== ts.CharacterCodes.slash) {`
`116`	`115`	`url = "/" + url;`
`117`	`116`	`}`
`118`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,11 +50,11 @@ namespace Harness.SourceMapRecorder {`
`50`	`50`	`return true;`
`51`	`51`	`}`
`52`	`52`
`53`		`- if (sourceMapMappings.charAt(decodingIndex) == ",") {`
	`53`	`+ if (sourceMapMappings.charAt(decodingIndex) === ",") {`
`54`	`54`	`return true;`
`55`	`55`	`}`
`56`	`56`
`57`		`- if (sourceMapMappings.charAt(decodingIndex) == ";") {`
	`57`	`+ if (sourceMapMappings.charAt(decodingIndex) === ";") {`
`58`	`58`	`return true;`
`59`	`59`	`}`
`60`	`60`
`@@ -117,15 +117,15 @@ namespace Harness.SourceMapRecorder {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`while (decodingIndex < sourceMapMappings.length) {`
`120`		`- if (sourceMapMappings.charAt(decodingIndex) == ";") {`
	`120`	`+ if (sourceMapMappings.charAt(decodingIndex) === ";") {`
`121`	`121`	`// New line`
`122`	`122`	`decodeOfEncodedMapping.emittedLine++;`
`123`	`123`	`decodeOfEncodedMapping.emittedColumn = 1;`
`124`	`124`	`decodingIndex++;`
`125`	`125`	`continue;`
`126`	`126`	`}`
`127`	`127`
`128`		`- if (sourceMapMappings.charAt(decodingIndex) == ",") {`
	`128`	`+ if (sourceMapMappings.charAt(decodingIndex) === ",") {`
`129`	`129`	`// Next entry is on same line - no action needed`
`130`	`130`	`decodingIndex++;`
`131`	`131`	`continue;`