isDeclarationName: support ComputedPropertyName (#22123)

* isDeclarationName: support ComputedPropertyName

* update additional baseline

Author: Andy

src/compiler/checker.ts

@@ -23094,7 +23094,7 @@ namespace ts {
                         const rootChain = () => chainDiagnosticMessages(
                             /*details*/ undefined,
                             Diagnostics.Property_0_in_type_1_is_not_assignable_to_the_same_property_in_base_type_2,
-                            unescapeLeadingUnderscores(declaredProp.escapedName),
+                            symbolToString(declaredProp),
                             typeToString(typeWithThis),
                             typeToString(baseWithThis)
                         );

src/compiler/utilities.ts

@@ -1860,16 +1860,9 @@ namespace ts {
         return false;
     }
 
-    // True if the given identifier, string literal, or number literal is the name of a declaration node
+    // True if `name` is the name of a declaration node
     export function isDeclarationName(name: Node): boolean {
-        switch (name.kind) {
-            case SyntaxKind.Identifier:
-            case SyntaxKind.StringLiteral:
-            case SyntaxKind.NumericLiteral:
-                return isDeclaration(name.parent) && name.parent.name === name;
-            default:
-                return false;
-        }
+        return !isSourceFile(name) && !isBindingPattern(name) && isDeclaration(name.parent) && name.parent.name === name;
     }
 
     // See GH#16030

src/harness/harness.ts

@@ -1532,7 +1532,7 @@ namespace Harness {
             }
 
             if (typesError && symbolsError) {
-                throw new Error(typesError.message + Harness.IO.newLine() + symbolsError.message);
+                throw new Error(typesError.stack + Harness.IO.newLine() + symbolsError.stack);
             }
 
             if (typesError) {

tests/baselines/reference/ES5For-ofTypeCheck10.symbols

@@ -16,6 +16,8 @@ class StringIterator {
         };
     }
     [Symbol.iterator]() {
+>[Symbol.iterator] : Symbol(StringIterator[Symbol.iterator], Decl(ES5For-ofTypeCheck10.ts, 7, 5))
+
         return this;
 >this : Symbol(StringIterator, Decl(ES5For-ofTypeCheck10.ts, 0, 0))
     }

tests/baselines/reference/ES5For-ofTypeCheck10.types

@@ -20,6 +20,7 @@ class StringIterator {
         };
     }
     [Symbol.iterator]() {
+>[Symbol.iterator] : () => this
 >Symbol.iterator : any
 >Symbol : any
 >iterator : any

tests/baselines/reference/ES5SymbolProperty1.symbols

@@ -13,6 +13,7 @@ var obj = {
 >obj : Symbol(obj, Decl(ES5SymbolProperty1.ts, 5, 3))
 
     [Symbol.foo]: 0
+>[Symbol.foo] : Symbol([Symbol.foo], Decl(ES5SymbolProperty1.ts, 5, 11))
 >Symbol.foo : Symbol(SymbolConstructor.foo, Decl(ES5SymbolProperty1.ts, 0, 29))
 >Symbol : Symbol(Symbol, Decl(ES5SymbolProperty1.ts, 3, 3))
 >foo : Symbol(SymbolConstructor.foo, Decl(ES5SymbolProperty1.ts, 0, 29))

tests/baselines/reference/ES5SymbolProperty1.types

@@ -14,6 +14,7 @@ var obj = {
 >{    [Symbol.foo]: 0} : { [Symbol.foo]: number; }
 
     [Symbol.foo]: 0
+>[Symbol.foo] : number
 >Symbol.foo : string
 >Symbol : SymbolConstructor
 >foo : string

tests/baselines/reference/ES5SymbolProperty2.symbols

@@ -9,6 +9,7 @@ module M {
 >C : Symbol(C, Decl(ES5SymbolProperty2.ts, 1, 20))
 
         [Symbol.iterator]() { }
+>[Symbol.iterator] : Symbol(C[Symbol.iterator], Decl(ES5SymbolProperty2.ts, 3, 20))
 >Symbol : Symbol(Symbol, Decl(ES5SymbolProperty2.ts, 1, 7))
     }
     (new C)[Symbol.iterator];

tests/baselines/reference/ES5SymbolProperty2.types

@@ -9,6 +9,7 @@ module M {
 >C : C
 
         [Symbol.iterator]() { }
+>[Symbol.iterator] : () => void
 >Symbol.iterator : any
 >Symbol : any
 >iterator : any

tests/baselines/reference/ES5SymbolProperty3.symbols

@@ -6,6 +6,7 @@ class C {
 >C : Symbol(C, Decl(ES5SymbolProperty3.ts, 0, 16))
 
     [Symbol.iterator]() { }
+>[Symbol.iterator] : Symbol(C[Symbol.iterator], Decl(ES5SymbolProperty3.ts, 2, 9))
 >Symbol : Symbol(Symbol, Decl(ES5SymbolProperty3.ts, 0, 3))
 }