Allow expando additions to an imported object in JavaScript - fixes #…

…31312
microsoft · Jul 30, 2019 · 946a14f · 946a14f
1 parent dbe9e3d
commit 946a14f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 14 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -29974,7 +29974,7 @@ namespace ts {
             const symbol = getSymbolOfNode(node);
             const target = resolveAlias(symbol);
             if (target !== unknownSymbol) {
-                // For external modules symbol represent local symbol for an alias.
+                // For external modules symbol represents local symbol for an alias.
                 // This local symbol will merge any other local declarations (excluding other aliases)
                 // and symbol.flags will contains combined representation for all merged declaration.
                 // Based on symbol.flags we can compute a set of excluded meanings (meaning that resolved alias should not have,
@@ -30004,7 +30004,9 @@ namespace ts {
         function checkImportBinding(node: ImportEqualsDeclaration | ImportClause | NamespaceImport | ImportSpecifier) {
             checkCollisionWithRequireExportsInGeneratedCode(node, node.name!);
             checkCollisionWithGlobalPromiseInGeneratedCode(node, node.name!);
-            checkAliasSymbol(node);
+            if (!isInJSFile(node)) {
+                checkAliasSymbol(node);
+            }
         }
 
         function checkImportDeclaration(node: ImportDeclaration) {

diff --git a/src/compiler/debug.ts b/src/compiler/debug.ts
@@ -258,4 +258,4 @@ namespace ts {
             isDebugInfoEnabled = true;
         }
     }
-}
+}
diff --git a/tests/baselines/reference/propertyAssignmentOnImportedSymbol.errors.txt b/tests/baselines/reference/propertyAssignmentOnImportedSymbol.errors.txt