Skip to content

Commit 8f8f306

Browse files
author
Andy
committed
Hack to allow concat to work even when an Array isn't assignable to ReadonlyArray (#20455)
1 parent 9bf965a commit 8f8f306

20 files changed

+144
-47
lines changed

‎src/lib/es5.d.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -980,12 +980,13 @@ interface ReadonlyArray<T> {
980980
* Combines two or more arrays.
981981
* @param items Additional items to add to the end of array1.
982982
*/
983-
concat(...items: ReadonlyArray<T>[]): T[];
983+
// TODO: https://github.com/Microsoft/TypeScript/issues/20454
984+
concat(...items: (T[] | ReadonlyArray<T>)[]): T[];
984985
/**
985986
* Combines two or more arrays.
986987
* @param items Additional items to add to the end of array1.
987988
*/
988-
concat(...items: (T | ReadonlyArray<T>)[]): T[];
989+
concat(...items: (T | T[] | ReadonlyArray<T>)[]): T[];
989990
/**
990991
* Adds all the elements of an array separated by the specified separator string.
991992
* @param separator A string used to separate one element of an array from the next in the resulting String. If omitted, the array elements are separated with a comma.
@@ -1101,12 +1102,12 @@ interface Array<T> {
11011102
* Combines two or more arrays.
11021103
* @param items Additional items to add to the end of array1.
11031104
*/
1104-
concat(...items: ReadonlyArray<T>[]): T[];
1105+
concat(...items: (T[] | ReadonlyArray<T>)[]): T[];
11051106
/**
11061107
* Combines two or more arrays.
11071108
* @param items Additional items to add to the end of array1.
11081109
*/
1109-
concat(...items: (T | ReadonlyArray<T>)[]): T[];
1110+
concat(...items: (T | T[] | ReadonlyArray<T>)[]): T[];
11101111
/**
11111112
* Adds all the elements of an array separated by the specified separator string.
11121113
* @param separator A string used to separate one element of an array from the next in the resulting String. If omitted, the array elements are separated with a comma.

‎tests/baselines/reference/arrayConcat2.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ var a: string[] = [];
55

66
a.concat("hello", 'world');
77
>a.concat("hello", 'world') : string[]
8-
>a.concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
8+
>a.concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
99
>a : string[]
10-
>concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
10+
>concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
1111
>"hello" : "hello"
1212
>'world' : "world"
1313

1414
a.concat('Hello');
1515
>a.concat('Hello') : string[]
16-
>a.concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
16+
>a.concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
1717
>a : string[]
18-
>concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
18+
>concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
1919
>'Hello' : "Hello"
2020

2121
var b = new Array<string>();
@@ -25,8 +25,8 @@ var b = new Array<string>();
2525

2626
b.concat('hello');
2727
>b.concat('hello') : string[]
28-
>b.concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
28+
>b.concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
2929
>b : string[]
30-
>concat : { (...items: ReadonlyArray<string>[]): string[]; (...items: (string | ReadonlyArray<string>)[]): string[]; }
30+
>concat : { (...items: (string[] | ReadonlyArray<string>)[]): string[]; (...items: (string | string[] | ReadonlyArray<string>)[]): string[]; }
3131
>'hello' : "hello"
3232

‎tests/baselines/reference/arrayConcat3.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
//// [arrayConcat3.ts]
2+
// TODO: remove lib hack when https://github.com/Microsoft/TypeScript/issues/20454 is fixed
3+
type Fn<T extends object> = <U extends T>(subj: U) => U
4+
function doStuff<T extends object, T1 extends T>(a: Array<Fn<T>>, b: Array<Fn<T1>>) {
5+
b.concat(a);
6+
}
7+
8+
9+
//// [arrayConcat3.js]
10+
function doStuff(a, b) {
11+
b.concat(a);
12+
}

‎tests/baselines/reference/arrayConcat3.symbols

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
=== tests/cases/compiler/arrayConcat3.ts ===
2+
// TODO: remove lib hack when https://github.com/Microsoft/TypeScript/issues/20454 is fixed
3+
type Fn<T extends object> = <U extends T>(subj: U) => U
4+
>Fn : Symbol(Fn, Decl(arrayConcat3.ts, 0, 0))
5+
>T : Symbol(T, Decl(arrayConcat3.ts, 1, 8))
6+
>U : Symbol(U, Decl(arrayConcat3.ts, 1, 29))
7+
>T : Symbol(T, Decl(arrayConcat3.ts, 1, 8))
8+
>subj : Symbol(subj, Decl(arrayConcat3.ts, 1, 42))
9+
>U : Symbol(U, Decl(arrayConcat3.ts, 1, 29))
10+
>U : Symbol(U, Decl(arrayConcat3.ts, 1, 29))
11+
12+
function doStuff<T extends object, T1 extends T>(a: Array<Fn<T>>, b: Array<Fn<T1>>) {
13+
>doStuff : Symbol(doStuff, Decl(arrayConcat3.ts, 1, 55))
14+
>T : Symbol(T, Decl(arrayConcat3.ts, 2, 17))
15+
>T1 : Symbol(T1, Decl(arrayConcat3.ts, 2, 34))
16+
>T : Symbol(T, Decl(arrayConcat3.ts, 2, 17))
17+
>a : Symbol(a, Decl(arrayConcat3.ts, 2, 49))
18+
>Array : Symbol(Array, Decl(lib.d.ts, --, --), Decl(lib.d.ts, --, --))
19+
>Fn : Symbol(Fn, Decl(arrayConcat3.ts, 0, 0))
20+
>T : Symbol(T, Decl(arrayConcat3.ts, 2, 17))
21+
>b : Symbol(b, Decl(arrayConcat3.ts, 2, 65))
22+
>Array : Symbol(Array, Decl(lib.d.ts, --, --), Decl(lib.d.ts, --, --))
23+
>Fn : Symbol(Fn, Decl(arrayConcat3.ts, 0, 0))
24+
>T1 : Symbol(T1, Decl(arrayConcat3.ts, 2, 34))
25+
26+
b.concat(a);
27+
>b.concat : Symbol(Array.concat, Decl(lib.d.ts, --, --), Decl(lib.d.ts, --, --))
28+
>b : Symbol(b, Decl(arrayConcat3.ts, 2, 65))
29+
>concat : Symbol(Array.concat, Decl(lib.d.ts, --, --), Decl(lib.d.ts, --, --))
30+
>a : Symbol(a, Decl(arrayConcat3.ts, 2, 49))
31+
}
32+

‎tests/baselines/reference/arrayConcat3.types

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
=== tests/cases/compiler/arrayConcat3.ts ===
2+
// TODO: remove lib hack when https://github.com/Microsoft/TypeScript/issues/20454 is fixed
3+
type Fn<T extends object> = <U extends T>(subj: U) => U
4+
>Fn : Fn<T>
5+
>T : T
6+
>U : U
7+
>T : T
8+
>subj : U
9+
>U : U
10+
>U : U
11+
12+
function doStuff<T extends object, T1 extends T>(a: Array<Fn<T>>, b: Array<Fn<T1>>) {
13+
>doStuff : <T extends object, T1 extends T>(a: Fn<T>[], b: Fn<T1>[]) => void
14+
>T : T
15+
>T1 : T1
16+
>T : T
17+
>a : Fn<T>[]
18+
>Array : T[]
19+
>Fn : Fn<T>
20+
>T : T
21+
>b : Fn<T1>[]
22+
>Array : T[]
23+
>Fn : Fn<T>
24+
>T1 : T1
25+
26+
b.concat(a);
27+
>b.concat(a) : Fn<T1>[]
28+
>b.concat : { (...items: (Fn<T1>[] | ReadonlyArray<Fn<T1>>)[]): Fn<T1>[]; (...items: (Fn<T1> | Fn<T1>[] | ReadonlyArray<Fn<T1>>)[]): Fn<T1>[]; }
29+
>b : Fn<T1>[]
30+
>concat : { (...items: (Fn<T1>[] | ReadonlyArray<Fn<T1>>)[]): Fn<T1>[]; (...items: (Fn<T1> | Fn<T1>[] | ReadonlyArray<Fn<T1>>)[]): Fn<T1>[]; }
31+
>a : Fn<T>[]
32+
}
33+

‎tests/baselines/reference/arrayConcatMap.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ var x = [].concat([{ a: 1 }], [{ a: 2 }])
44
>[].concat([{ a: 1 }], [{ a: 2 }]) .map(b => b.a) : any[]
55
>[].concat([{ a: 1 }], [{ a: 2 }]) .map : <U>(callbackfn: (value: any, index: number, array: any[]) => U, thisArg?: any) => U[]
66
>[].concat([{ a: 1 }], [{ a: 2 }]) : any[]
7-
>[].concat : { (...items: ReadonlyArray<any>[]): any[]; (...items: any[]): any[]; }
7+
>[].concat : { (...items: (any[] | ReadonlyArray<any>)[]): any[]; (...items: any[]): any[]; }
88
>[] : undefined[]
9-
>concat : { (...items: ReadonlyArray<any>[]): any[]; (...items: any[]): any[]; }
9+
>concat : { (...items: (any[] | ReadonlyArray<any>)[]): any[]; (...items: any[]): any[]; }
1010
>[{ a: 1 }] : { a: number; }[]
1111
>{ a: 1 } : { a: number; }
1212
>a : number

‎tests/baselines/reference/arrayOfSubtypeIsAssignableToReadonlyArray.errors.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
tests/cases/compiler/arrayOfSubtypeIsAssignableToReadonlyArray.ts(13,1): error TS2322: Type 'A[]' is not assignable to type 'ReadonlyArray<B>'.
22
Types of property 'concat' are incompatible.
3-
Type '{ (...items: ReadonlyArray<A>[]): A[]; (...items: (A | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: ReadonlyArray<B>[]): B[]; (...items: (B | ReadonlyArray<B>)[]): B[]; }'.
3+
Type '{ (...items: (A[] | ReadonlyArray<A>)[]): A[]; (...items: (A | A[] | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: (B[] | ReadonlyArray<B>)[]): B[]; (...items: (B | B[] | ReadonlyArray<B>)[]): B[]; }'.
44
Type 'A[]' is not assignable to type 'B[]'.
55
Type 'A' is not assignable to type 'B'.
66
Property 'b' is missing in type 'A'.
77
tests/cases/compiler/arrayOfSubtypeIsAssignableToReadonlyArray.ts(18,1): error TS2322: Type 'C<A>' is not assignable to type 'ReadonlyArray<B>'.
88
Types of property 'concat' are incompatible.
9-
Type '{ (...items: ReadonlyArray<A>[]): A[]; (...items: (A | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: ReadonlyArray<B>[]): B[]; (...items: (B | ReadonlyArray<B>)[]): B[]; }'.
9+
Type '{ (...items: (A[] | ReadonlyArray<A>)[]): A[]; (...items: (A | A[] | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: (B[] | ReadonlyArray<B>)[]): B[]; (...items: (B | B[] | ReadonlyArray<B>)[]): B[]; }'.
1010
Type 'A[]' is not assignable to type 'B[]'.
1111

1212

@@ -27,7 +27,7 @@ tests/cases/compiler/arrayOfSubtypeIsAssignableToReadonlyArray.ts(18,1): error T
2727
~~~
2828
!!! error TS2322: Type 'A[]' is not assignable to type 'ReadonlyArray<B>'.
2929
!!! error TS2322: Types of property 'concat' are incompatible.
30-
!!! error TS2322: Type '{ (...items: ReadonlyArray<A>[]): A[]; (...items: (A | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: ReadonlyArray<B>[]): B[]; (...items: (B | ReadonlyArray<B>)[]): B[]; }'.
30+
!!! error TS2322: Type '{ (...items: (A[] | ReadonlyArray<A>)[]): A[]; (...items: (A | A[] | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: (B[] | ReadonlyArray<B>)[]): B[]; (...items: (B | B[] | ReadonlyArray<B>)[]): B[]; }'.
3131
!!! error TS2322: Type 'A[]' is not assignable to type 'B[]'.
3232
!!! error TS2322: Type 'A' is not assignable to type 'B'.
3333
!!! error TS2322: Property 'b' is missing in type 'A'.
@@ -39,6 +39,6 @@ tests/cases/compiler/arrayOfSubtypeIsAssignableToReadonlyArray.ts(18,1): error T
3939
~~~
4040
!!! error TS2322: Type 'C<A>' is not assignable to type 'ReadonlyArray<B>'.
4141
!!! error TS2322: Types of property 'concat' are incompatible.
42-
!!! error TS2322: Type '{ (...items: ReadonlyArray<A>[]): A[]; (...items: (A | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: ReadonlyArray<B>[]): B[]; (...items: (B | ReadonlyArray<B>)[]): B[]; }'.
42+
!!! error TS2322: Type '{ (...items: (A[] | ReadonlyArray<A>)[]): A[]; (...items: (A | A[] | ReadonlyArray<A>)[]): A[]; }' is not assignable to type '{ (...items: (B[] | ReadonlyArray<B>)[]): B[]; (...items: (B | B[] | ReadonlyArray<B>)[]): B[]; }'.
4343
!!! error TS2322: Type 'A[]' is not assignable to type 'B[]'.
4444

‎tests/baselines/reference/concatError.types

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ fa = fa.concat([0]);
1515
>fa = fa.concat([0]) : number[]
1616
>fa : number[]
1717
>fa.concat([0]) : number[]
18-
>fa.concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
18+
>fa.concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
1919
>fa : number[]
20-
>concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
20+
>concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
2121
>[0] : number[]
2222
>0 : 0
2323

2424
fa = fa.concat(0);
2525
>fa = fa.concat(0) : number[]
2626
>fa : number[]
2727
>fa.concat(0) : number[]
28-
>fa.concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
28+
>fa.concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
2929
>fa : number[]
30-
>concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
30+
>concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
3131
>0 : 0
3232

3333

‎tests/baselines/reference/concatTuples.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ ijs = ijs.concat([[3, 4], [5, 6]]);
1010
>ijs = ijs.concat([[3, 4], [5, 6]]) : [number, number][]
1111
>ijs : [number, number][]
1212
>ijs.concat([[3, 4], [5, 6]]) : [number, number][]
13-
>ijs.concat : { (...items: ReadonlyArray<[number, number]>[]): [number, number][]; (...items: ([number, number] | ReadonlyArray<[number, number]>)[]): [number, number][]; }
13+
>ijs.concat : { (...items: ([number, number][] | ReadonlyArray<[number, number]>)[]): [number, number][]; (...items: ([number, number] | [number, number][] | ReadonlyArray<[number, number]>)[]): [number, number][]; }
1414
>ijs : [number, number][]
15-
>concat : { (...items: ReadonlyArray<[number, number]>[]): [number, number][]; (...items: ([number, number] | ReadonlyArray<[number, number]>)[]): [number, number][]; }
15+
>concat : { (...items: ([number, number][] | ReadonlyArray<[number, number]>)[]): [number, number][]; (...items: ([number, number] | [number, number][] | ReadonlyArray<[number, number]>)[]): [number, number][]; }
1616
>[[3, 4], [5, 6]] : [number, number][]
1717
>[3, 4] : [number, number]
1818
>3 : 3

‎tests/baselines/reference/emitSkipsThisWithRestParameter.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ function rebase(fn: (base: any, ...args: any[]) => any): (...args: any[]) => any
1818
>apply : (this: Function, thisArg: any, argArray?: any) => any
1919
>this : any
2020
>[ this ].concat(args) : any[]
21-
>[ this ].concat : { (...items: ReadonlyArray<any>[]): any[]; (...items: any[]): any[]; }
21+
>[ this ].concat : { (...items: (any[] | ReadonlyArray<any>)[]): any[]; (...items: any[]): any[]; }
2222
>[ this ] : any[]
2323
>this : any
24-
>concat : { (...items: ReadonlyArray<any>[]): any[]; (...items: any[]): any[]; }
24+
>concat : { (...items: (any[] | ReadonlyArray<any>)[]): any[]; (...items: any[]): any[]; }
2525
>args : any[]
2626

2727
};

‎tests/baselines/reference/iteratorSpreadInArray6.errors.txt

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
1-
tests/cases/conformance/es6/spread/iteratorSpreadInArray6.ts(15,14): error TS2345: Argument of type 'symbol[]' is not assignable to parameter of type 'number | ReadonlyArray<number>'.
1+
tests/cases/conformance/es6/spread/iteratorSpreadInArray6.ts(15,14): error TS2345: Argument of type 'symbol[]' is not assignable to parameter of type 'number | number[] | ReadonlyArray<number>'.
22
Type 'symbol[]' is not assignable to type 'ReadonlyArray<number>'.
33
Types of property 'concat' are incompatible.
4-
Type '{ (...items: ReadonlyArray<symbol>[]): symbol[]; (...items: (symbol | ReadonlyArray<symbol>)[]): symbol[]; }' is not assignable to type '{ (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }'.
4+
Type '{ (...items: (symbol[] | ReadonlyArray<symbol>)[]): symbol[]; (...items: (symbol | symbol[] | ReadonlyArray<symbol>)[]): symbol[]; }' is not assignable to type '{ (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }'.
55
Types of parameters 'items' and 'items' are incompatible.
6-
Type 'ReadonlyArray<number>' is not assignable to type 'ReadonlyArray<symbol>'.
7-
Type 'number' is not assignable to type 'symbol'.
6+
Type 'number[] | ReadonlyArray<number>' is not assignable to type 'symbol[] | ReadonlyArray<symbol>'.
7+
Type 'number[]' is not assignable to type 'symbol[] | ReadonlyArray<symbol>'.
8+
Type 'number[]' is not assignable to type 'ReadonlyArray<symbol>'.
9+
Types of property 'concat' are incompatible.
10+
Type '{ (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }' is not assignable to type '{ (...items: (symbol[] | ReadonlyArray<symbol>)[]): symbol[]; (...items: (symbol | symbol[] | ReadonlyArray<symbol>)[]): symbol[]; }'.
11+
Types of parameters 'items' and 'items' are incompatible.
12+
Type 'symbol[] | ReadonlyArray<symbol>' is not assignable to type 'number[] | ReadonlyArray<number>'.
13+
Type 'symbol[]' is not assignable to type 'number[] | ReadonlyArray<number>'.
14+
Type 'symbol[]' is not assignable to type 'ReadonlyArray<number>'.
815

916

1017
==== tests/cases/conformance/es6/spread/iteratorSpreadInArray6.ts (1 errors) ====
@@ -24,10 +31,17 @@ tests/cases/conformance/es6/spread/iteratorSpreadInArray6.ts(15,14): error TS234
2431
var array: number[] = [0, 1];
2532
array.concat([...new SymbolIterator]);
2633
~~~~~~~~~~~~~~~~~~~~~~~
27-
!!! error TS2345: Argument of type 'symbol[]' is not assignable to parameter of type 'number | ReadonlyArray<number>'.
34+
!!! error TS2345: Argument of type 'symbol[]' is not assignable to parameter of type 'number | number[] | ReadonlyArray<number>'.
2835
!!! error TS2345: Type 'symbol[]' is not assignable to type 'ReadonlyArray<number>'.
2936
!!! error TS2345: Types of property 'concat' are incompatible.
30-
!!! error TS2345: Type '{ (...items: ReadonlyArray<symbol>[]): symbol[]; (...items: (symbol | ReadonlyArray<symbol>)[]): symbol[]; }' is not assignable to type '{ (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }'.
37+
!!! error TS2345: Type '{ (...items: (symbol[] | ReadonlyArray<symbol>)[]): symbol[]; (...items: (symbol | symbol[] | ReadonlyArray<symbol>)[]): symbol[]; }' is not assignable to type '{ (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }'.
3138
!!! error TS2345: Types of parameters 'items' and 'items' are incompatible.
32-
!!! error TS2345: Type 'ReadonlyArray<number>' is not assignable to type 'ReadonlyArray<symbol>'.
33-
!!! error TS2345: Type 'number' is not assignable to type 'symbol'.
39+
!!! error TS2345: Type 'number[] | ReadonlyArray<number>' is not assignable to type 'symbol[] | ReadonlyArray<symbol>'.
40+
!!! error TS2345: Type 'number[]' is not assignable to type 'symbol[] | ReadonlyArray<symbol>'.
41+
!!! error TS2345: Type 'number[]' is not assignable to type 'ReadonlyArray<symbol>'.
42+
!!! error TS2345: Types of property 'concat' are incompatible.
43+
!!! error TS2345: Type '{ (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }' is not assignable to type '{ (...items: (symbol[] | ReadonlyArray<symbol>)[]): symbol[]; (...items: (symbol | symbol[] | ReadonlyArray<symbol>)[]): symbol[]; }'.
44+
!!! error TS2345: Types of parameters 'items' and 'items' are incompatible.
45+
!!! error TS2345: Type 'symbol[] | ReadonlyArray<symbol>' is not assignable to type 'number[] | ReadonlyArray<number>'.
46+
!!! error TS2345: Type 'symbol[]' is not assignable to type 'number[] | ReadonlyArray<number>'.
47+
!!! error TS2345: Type 'symbol[]' is not assignable to type 'ReadonlyArray<number>'.

‎tests/baselines/reference/iteratorSpreadInArray6.types

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ var array: number[] = [0, 1];
3838

3939
array.concat([...new SymbolIterator]);
4040
>array.concat([...new SymbolIterator]) : any
41-
>array.concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
41+
>array.concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
4242
>array : number[]
43-
>concat : { (...items: ReadonlyArray<number>[]): number[]; (...items: (number | ReadonlyArray<number>)[]): number[]; }
43+
>concat : { (...items: (number[] | ReadonlyArray<number>)[]): number[]; (...items: (number | number[] | ReadonlyArray<number>)[]): number[]; }
4444
>[...new SymbolIterator] : symbol[]
4545
>...new SymbolIterator : symbol
4646
>new SymbolIterator : SymbolIterator

0 commit comments

Comments
 (0)