Making APIs as internal so that we can enable them after we have figured out final details

Author: sheetalkamat

src/compiler/builder.ts

@@ -18,18 +18,12 @@ namespace ts {
         text: string;
     }
 
-    export interface ChangedProgramFiles {
-        /** Minimal set of list of files that require emit */
-        readonly filesToEmit: ReadonlyArray<string>;
-        /** File paths of source files changed/added/removed or affected by changed files */
-        readonly changedFiles: ReadonlyArray<string>;
-    }
-
+    /* @internal */
     export interface Builder {
         /**
-         * This is the callback when file infos in the builder are updated
+         * Call this to feed new program
          */
-        onProgramUpdateGraph(program: Program, hasInvalidatedResolution: HasInvalidatedResolution): void;
+        updateProgram(newProgram: Program): void;
         getFilesAffectedBy(program: Program, path: Path): string[];
         emitFile(program: Program, path: Path): EmitOutput;
 
@@ -97,6 +91,7 @@ namespace ts {
         signature: string;
     }
 
+    /* @internal */
     export function createBuilder(
         getCanonicalFileName: (fileName: string) => string,
         getEmitOutput: (program: Program, sourceFile: SourceFile, emitOnlyDtsFiles: boolean, isDetailed: boolean) => EmitOutput | EmitOutputDetailed,
@@ -110,15 +105,15 @@ namespace ts {
         const changedFileNames = createMap<string>();
         let emitHandler: EmitHandler;
         return {
-            onProgramUpdateGraph,
+            updateProgram,
             getFilesAffectedBy,
             emitFile,
             emitChangedFiles,
             getSemanticDiagnostics,
             clear
         };
 
-        function createProgramGraph(program: Program, hasInvalidatedResolution: HasInvalidatedResolution) {
+        function createProgramGraph(program: Program) {
             const currentIsModuleEmit = program.getCompilerOptions().module !== ModuleKind.None;
             if (isModuleEmit !== currentIsModuleEmit) {
                 isModuleEmit = currentIsModuleEmit;
@@ -135,7 +130,7 @@ namespace ts {
                     // Remove existing file info
                     onDeleteValue: removeExistingFileInfo,
                     // We will update in place instead of deleting existing value and adding new one
-                    onExistingValue: (existingInfo, sourceFile) => updateExistingFileInfo(program, existingInfo, sourceFile, hasInvalidatedResolution)
+                    onExistingValue: (existingInfo, sourceFile) => updateExistingFileInfo(program, existingInfo, sourceFile)
                 }
             );
         }
@@ -157,27 +152,27 @@ namespace ts {
             emitHandler.onRemoveSourceFile(path);
         }
 
-        function updateExistingFileInfo(program: Program, existingInfo: FileInfo, sourceFile: SourceFile, hasInvalidatedResolution: HasInvalidatedResolution) {
+        function updateExistingFileInfo(program: Program, existingInfo: FileInfo, sourceFile: SourceFile) {
             if (existingInfo.version !== sourceFile.version) {
                 registerChangedFile(sourceFile.path, sourceFile.fileName);
                 existingInfo.version = sourceFile.version;
                 emitHandler.onUpdateSourceFile(program, sourceFile);
             }
-            else if (hasInvalidatedResolution(sourceFile.path) &&
+            else if (program.hasInvalidatedResolution(sourceFile.path) &&
                 emitHandler.onUpdateSourceFileWithSameVersion(program, sourceFile)) {
                 registerChangedFile(sourceFile.path, sourceFile.fileName);
             }
         }
 
         function ensureProgramGraph(program: Program) {
             if (!emitHandler) {
-                createProgramGraph(program, returnFalse);
+                createProgramGraph(program);
             }
         }
 
-        function onProgramUpdateGraph(program: Program, hasInvalidatedResolution: HasInvalidatedResolution) {
+        function updateProgram(newProgram: Program) {
             if (emitHandler) {
-                createProgramGraph(program, hasInvalidatedResolution);
+                createProgramGraph(newProgram);
             }
         }
 

src/compiler/program.ts

@@ -663,6 +663,7 @@ namespace ts {
             getSourceFileFromReference,
             sourceFileToPackageName,
             redirectTargetsSet,
+            hasInvalidatedResolution
         };
 
         verifyCompilerOptions();

src/compiler/types.ts

@@ -2525,6 +2525,8 @@ namespace ts {
         /* @internal */ sourceFileToPackageName: Map<string>;
         /** Set of all source files that some other source file redirects to. */
         /* @internal */ redirectTargetsSet: Map<true>;
+        /** Returns true when file in the program had invalidated resolution at the time of program creation. */
+        hasInvalidatedResolution: HasInvalidatedResolution;
     }
 
     /* @internal */

src/compiler/watch.ts

@@ -2,6 +2,7 @@
 /// <reference path="builder.ts" />
 /// <reference path="resolutionCache.ts"/>
 
+/* @internal */
 namespace ts {
     export type DiagnosticReporter = (diagnostic: Diagnostic) => void;
     export type ParseConfigFile = (configFileName: string, optionsToExtend: CompilerOptions, system: DirectoryStructureHost, reportDiagnostic: DiagnosticReporter, reportWatchDiagnostic: DiagnosticReporter) => ParsedCommandLine;
@@ -341,7 +342,7 @@ namespace ts {
             compilerHost.hasChangedAutomaticTypeDirectiveNames = hasChangedAutomaticTypeDirectiveNames;
             program = createProgram(rootFileNames, compilerOptions, compilerHost, program);
             resolutionCache.finishCachingPerDirectoryResolution();
-            builder.onProgramUpdateGraph(program, hasInvalidatedResolution);
+            builder.updateProgram(program);
 
             // Update watches
             updateMissingFilePathsWatch(program, missingFilesMap || (missingFilesMap = createMap()), watchMissingFilePath);