fix(50750): Object type literal with string literal property in conte…

…xtual typing position causes language service error on all literal type references (#50757) * fix(50750): skip unbound symbols from JSDoc tags in typescript * skip contextual type checking in JsDoc for TypeScript files
microsoft · Oct 3, 2022 · 7dcf11f · 7dcf11f
1 parent 5cd49f6
commit 7dcf11f
Show file tree

Hide file tree

Showing 5 changed files with 93 additions and 0 deletions.
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -790,6 +790,8 @@ namespace ts {
     }
 
     export function getContextualTypeFromParentOrAncestorTypeNode(node: Expression, checker: TypeChecker): Type | undefined {
+        if (node.flags & (NodeFlags.JSDoc & ~NodeFlags.JavaScriptFile)) return undefined;
+
         const contextualType = getContextualTypeFromParent(node, checker);
         if (contextualType) return contextualType;
 

diff --git a/tests/baselines/reference/findAllRefsForStringLiteral.baseline.jsonc b/tests/baselines/reference/findAllRefsForStringLiteral.baseline.jsonc
@@ -0,0 +1,52 @@
+// === /a.ts ===
+// interface Foo {
+//     property: /*FIND ALL REFS*/"[|foo|]";
+// }
+// /**
+//  * @type {{ property: "foo"}}
+//  */
+// const obj: Foo = {
+//     property: "[|foo|]",
+// }
+
+[
+  {
+    "definition": {
+      "containerKind": "",
+      "containerName": "",
+      "fileName": "/a.ts",
+      "kind": "var",
+      "name": "foo",
+      "textSpan": {
+        "start": 31,
+        "length": 3
+      },
+      "displayParts": [
+        {
+          "text": "\"foo\"",
+          "kind": "stringLiteral"
+        }
+      ]
+    },
+    "references": [
+      {
+        "textSpan": {
+          "start": 31,
+          "length": 3
+        },
+        "fileName": "/a.ts",
+        "isWriteAccess": false,
+        "isInString": true
+      },
+      {
+        "textSpan": {
+          "start": 111,
+          "length": 3
+        },
+        "fileName": "/a.ts",
+        "isWriteAccess": false,
+        "isInString": true
+      }
+    ]
+  }
+]
diff --git a/tests/baselines/reference/renameForStringLiteral.baseline b/tests/baselines/reference/renameForStringLiteral.baseline
@@ -0,0 +1,11 @@
+/*====== /a.ts ======*/
+
+interface Foo {
+    property: "RENAME";
+}
+/**
+ * @type {{ property: "foo"}}
+ */
+const obj: Foo = {
+    property: "RENAME",
+}
diff --git a/tests/cases/fourslash/findAllRefsForStringLiteral.ts b/tests/cases/fourslash/findAllRefsForStringLiteral.ts
@@ -0,0 +1,14 @@
+/// <reference path="fourslash.ts" />
+
+// @filename: /a.ts
+////interface Foo {
+////    property: /**/"foo";
+////}
+/////**
+//// * @type {{ property: "foo"}}
+//// */
+////const obj: Foo = {
+////    property: "foo",
+////}
+
+verify.baselineFindAllReferences("");
diff --git a/tests/cases/fourslash/renameForStringLiteral.ts b/tests/cases/fourslash/renameForStringLiteral.ts
@@ -0,0 +1,14 @@
+/// <reference path="fourslash.ts" />
+
+// @filename: /a.ts
+////interface Foo {
+////    property: /**/"foo";
+////}
+/////**
+//// * @type {{ property: "foo"}}
+//// */
+////const obj: Foo = {
+////    property: "foo",
+////}
+
+verify.baselineRename("", {});