Don't exclusively check for just JS but scope down the check to not i…

…nclude the expando'd objects
microsoft · Jul 31, 2019 · 44b13ee · 44b13ee
1 parent 8dd5706
commit 44b13ee
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -29974,9 +29974,8 @@ namespace ts {
             const symbol = getSymbolOfNode(node);
             const target = resolveAlias(symbol);
 
-            const shouldSkipWithJSRequireTargets = !isInJSFile(node) && moduleKind !== ModuleKind.ES2015;
-
-            if (shouldSkipWithJSRequireTargets && target !== unknownSymbol) {
+            const shouldSkipWithJSExpandoTargets = symbol.flags & SymbolFlags.Assignment;
+            if (!shouldSkipWithJSExpandoTargets && target !== unknownSymbol) {
                 // For external modules symbol represents local symbol for an alias.
                 // This local symbol will merge any other local declarations (excluding other aliases)
                 // and symbol.flags will contains combined representation for all merged declaration.