Skip to content

Commit 3cbd552

Browse files
committed
Skip suggestwidget telemetry if its already open Fixes #54667
1 parent 322390c commit 3cbd552

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

src/vs/editor/contrib/suggest/suggestWidget.ts

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -704,18 +704,21 @@ export class SuggestWidget implements IContentWidget, IVirtualDelegate<ICompleti
704704
this.completionModel = null;
705705

706706
} else {
707-
const { stats } = this.completionModel;
708-
stats['wasAutomaticallyTriggered'] = !!isAuto;
709-
/* __GDPR__
710-
"suggestWidget" : {
711-
"wasAutomaticallyTriggered" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
712-
"${include}": [
713-
"${ICompletionStats}",
714-
"${EditorTelemetryData}"
715-
]
716-
}
717-
*/
718-
this.telemetryService.publicLog('suggestWidget', { ...stats, ...this.editor.getTelemetryData() });
707+
708+
if (this.state !== State.Open) {
709+
const { stats } = this.completionModel;
710+
stats['wasAutomaticallyTriggered'] = !!isAuto;
711+
/* __GDPR__
712+
"suggestWidget" : {
713+
"wasAutomaticallyTriggered" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
714+
"${include}": [
715+
"${ICompletionStats}",
716+
"${EditorTelemetryData}"
717+
]
718+
}
719+
*/
720+
this.telemetryService.publicLog('suggestWidget', { ...stats, ...this.editor.getTelemetryData() });
721+
}
719722

720723
this.list.splice(0, this.list.length, this.completionModel.items);
721724

0 commit comments

Comments
 (0)