add a test for setter assignment return value

Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com>

Author: mkubilayk

tests/baselines/reference/privateNameAccessors.js

@@ -20,7 +20,8 @@ var __classPrivateAccessorSet = (this && this.__classPrivateAccessorSet) || func
     if (!instances.has(receiver)) {
         throw new TypeError("attempted to set private accessor on non-instance");
     }
-    return fn.call(receiver, value);
+    fn.call(receiver, value);
+    return value;
 };
 var __classPrivateReadonly = (this && this.__classPrivateReadonly) || function () {
     throw new TypeError("private element is not writable");

tests/baselines/reference/privateNameSetterExprReturnValue.js

@@ -0,0 +1,32 @@
+//// [privateNameSetterExprReturnValue.ts]
+class C {
+    set #foo(a: number) {}
+    bar() {
+        let x = (this.#foo = 42 * 2);
+        console.log(x); // 84
+    }
+}
+
+new C().bar();
+
+
+//// [privateNameSetterExprReturnValue.js]
+var __classPrivateAccessorSet = (this && this.__classPrivateAccessorSet) || function (receiver, instances, fn, value) {
+    if (!instances.has(receiver)) {
+        throw new TypeError("attempted to set private accessor on non-instance");
+    }
+    fn.call(receiver, value);
+    return value;
+};
+var _C_foo_set, _C_instances;
+class C {
+    constructor() {
+        _C_instances.add(this);
+    }
+    bar() {
+        let x = (__classPrivateAccessorSet(this, _C_instances, _C_foo_set, 42 * 2));
+        console.log(x); // 84
+    }
+}
+_C_instances = new WeakSet(), _C_foo_set = function _C_foo_set(a) { };
+new C().bar();

tests/baselines/reference/privateNameSetterExprReturnValue.symbols

@@ -0,0 +1,29 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameSetterExprReturnValue.ts ===
+class C {
+>C : Symbol(C, Decl(privateNameSetterExprReturnValue.ts, 0, 0))
+
+    set #foo(a: number) {}
+>#foo : Symbol(C.#foo, Decl(privateNameSetterExprReturnValue.ts, 0, 9))
+>a : Symbol(a, Decl(privateNameSetterExprReturnValue.ts, 1, 13))
+
+    bar() {
+>bar : Symbol(C.bar, Decl(privateNameSetterExprReturnValue.ts, 1, 26))
+
+        let x = (this.#foo = 42 * 2);
+>x : Symbol(x, Decl(privateNameSetterExprReturnValue.ts, 3, 11))
+>this.#foo : Symbol(C.#foo, Decl(privateNameSetterExprReturnValue.ts, 0, 9))
+>this : Symbol(C, Decl(privateNameSetterExprReturnValue.ts, 0, 0))
+
+        console.log(x); // 84
+>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
+>console : Symbol(console, Decl(lib.dom.d.ts, --, --))
+>log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
+>x : Symbol(x, Decl(privateNameSetterExprReturnValue.ts, 3, 11))
+    }
+}
+
+new C().bar();
+>new C().bar : Symbol(C.bar, Decl(privateNameSetterExprReturnValue.ts, 1, 26))
+>C : Symbol(C, Decl(privateNameSetterExprReturnValue.ts, 0, 0))
+>bar : Symbol(C.bar, Decl(privateNameSetterExprReturnValue.ts, 1, 26))
+

tests/baselines/reference/privateNameSetterExprReturnValue.types

@@ -0,0 +1,37 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameSetterExprReturnValue.ts ===
+class C {
+>C : C
+
+    set #foo(a: number) {}
+>#foo : number
+>a : number
+
+    bar() {
+>bar : () => void
+
+        let x = (this.#foo = 42 * 2);
+>x : number
+>(this.#foo = 42 * 2) : number
+>this.#foo = 42 * 2 : number
+>this.#foo : number
+>this : this
+>42 * 2 : number
+>42 : 42
+>2 : 2
+
+        console.log(x); // 84
+>console.log(x) : void
+>console.log : (...data: any[]) => void
+>console : Console
+>log : (...data: any[]) => void
+>x : number
+    }
+}
+
+new C().bar();
+>new C().bar() : void
+>new C().bar : () => void
+>new C() : C
+>C : typeof C
+>bar : () => void
+

tests/baselines/reference/privateNameSetterNoGetter.js

@@ -17,7 +17,8 @@ var __classPrivateAccessorSet = (this && this.__classPrivateAccessorSet) || func
     if (!instances.has(receiver)) {
         throw new TypeError("attempted to set private accessor on non-instance");
     }
-    return fn.call(receiver, value);
+    fn.call(receiver, value);
+    return value;
 };
 var _C_x_set, _C_instances, _a;
 const C = (_a = class {

tests/cases/conformance/classes/members/privateNames/privateNameSetterExprReturnValue.ts

@@ -0,0 +1,11 @@
+// @target: es2019
+
+class C {
+    set #foo(a: number) {}
+    bar() {
+        let x = (this.#foo = 42 * 2);
+        console.log(x); // 84
+    }
+}
+
+new C().bar();