fix(38295): handle duplicate object literal keys which contain '+' and '-' tokens

Author: a-tarasyuk

src/compiler/utilities.ts

@@ -3092,6 +3092,9 @@ namespace ts {
                 else if (isStringOrNumericLiteralLike(nameExpression)) {
                     return escapeLeadingUnderscores(nameExpression.text);
                 }
+                else if (isSignedNumericLiteral(nameExpression)) {
+                    return tokenToString(nameExpression.operator) + nameExpression.operand.text as __String;
+                }
                 return undefined;
             default:
                 return Debug.assertNever(name);

tests/baselines/reference/duplicateObjectLiteralProperty_computedName.errors.txt

@@ -0,0 +1,27 @@
+tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts(3,5): error TS2300: Duplicate identifier '[1]'.
+tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts(8,5): error TS2300: Duplicate identifier '[-1]'.
+tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts(13,5): error TS2300: Duplicate identifier '[+1]'.
+
+
+==== tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts (3 errors) ====
+    const a = {
+        1: 0,
+        [1]: 0 // Duplicate
+        ~~~
+!!! error TS2300: Duplicate identifier '[1]'.
+    }
+    
+    const b = {
+        "-1": 0,
+        [-1]: 0 // Duplicate
+        ~~~~
+!!! error TS2300: Duplicate identifier '[-1]'.
+    }
+    
+    const c = {
+        "+1": 0,
+        [+1]: 0 // Duplicate
+        ~~~~
+!!! error TS2300: Duplicate identifier '[+1]'.
+    }
+    

tests/baselines/reference/duplicateObjectLiteralProperty_computedName.js

@@ -0,0 +1,37 @@
+//// [duplicateObjectLiteralProperty_computedName.ts]
+const a = {
+    1: 0,
+    [1]: 0 // Duplicate
+}
+
+const b = {
+    "-1": 0,
+    [-1]: 0 // Duplicate
+}
+
+const c = {
+    "+1": 0,
+    [+1]: 0 // Duplicate
+}
+
+
+//// [duplicateObjectLiteralProperty_computedName.js]
+var _a, _b, _c;
+var a = (_a = {
+        1: 0
+    },
+    _a[1] = 0 // Duplicate
+,
+    _a);
+var b = (_b = {
+        "-1": 0
+    },
+    _b[-1] = 0 // Duplicate
+,
+    _b);
+var c = (_c = {
+        "+1": 0
+    },
+    _c[+1] = 0 // Duplicate
+,
+    _c);

tests/baselines/reference/duplicateObjectLiteralProperty_computedName.symbols

@@ -0,0 +1,32 @@
+=== tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts ===
+const a = {
+>a : Symbol(a, Decl(duplicateObjectLiteralProperty_computedName.ts, 0, 5))
+
+    1: 0,
+>1 : Symbol(1, Decl(duplicateObjectLiteralProperty_computedName.ts, 0, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 1, 9))
+
+    [1]: 0 // Duplicate
+>[1] : Symbol(1, Decl(duplicateObjectLiteralProperty_computedName.ts, 0, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 1, 9))
+>1 : Symbol(1, Decl(duplicateObjectLiteralProperty_computedName.ts, 0, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 1, 9))
+}
+
+const b = {
+>b : Symbol(b, Decl(duplicateObjectLiteralProperty_computedName.ts, 5, 5))
+
+    "-1": 0,
+>"-1" : Symbol("-1", Decl(duplicateObjectLiteralProperty_computedName.ts, 5, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 6, 12))
+
+    [-1]: 0 // Duplicate
+>[-1] : Symbol("-1", Decl(duplicateObjectLiteralProperty_computedName.ts, 5, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 6, 12))
+}
+
+const c = {
+>c : Symbol(c, Decl(duplicateObjectLiteralProperty_computedName.ts, 10, 5))
+
+    "+1": 0,
+>"+1" : Symbol("+1", Decl(duplicateObjectLiteralProperty_computedName.ts, 10, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 11, 12))
+
+    [+1]: 0 // Duplicate
+>[+1] : Symbol("+1", Decl(duplicateObjectLiteralProperty_computedName.ts, 10, 11), Decl(duplicateObjectLiteralProperty_computedName.ts, 11, 12))
+}
+

tests/baselines/reference/duplicateObjectLiteralProperty_computedName.types

@@ -0,0 +1,45 @@
+=== tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts ===
+const a = {
+>a : { 1: number; }
+>{    1: 0,    [1]: 0 // Duplicate} : { 1: number; }
+
+    1: 0,
+>1 : number
+>0 : 0
+
+    [1]: 0 // Duplicate
+>[1] : number
+>1 : 1
+>0 : 0
+}
+
+const b = {
+>b : { [-1]: number; }
+>{    "-1": 0,    [-1]: 0 // Duplicate} : { [-1]: number; }
+
+    "-1": 0,
+>"-1" : number
+>0 : 0
+
+    [-1]: 0 // Duplicate
+>[-1] : number
+>-1 : -1
+>1 : 1
+>0 : 0
+}
+
+const c = {
+>c : { "+1": number; 1: number; }
+>{    "+1": 0,    [+1]: 0 // Duplicate} : { "+1": number; 1: number; }
+
+    "+1": 0,
+>"+1" : number
+>0 : 0
+
+    [+1]: 0 // Duplicate
+>[+1] : number
+>+1 : 1
+>1 : 1
+>0 : 0
+}
+

tests/cases/compiler/duplicateObjectLiteralProperty_computedName.ts

@@ -0,0 +1,14 @@
+const a = {
+    1: 0,
+    [1]: 0 // Duplicate
+}
+
+const b = {
+    "-1": 0,
+    [-1]: 0 // Duplicate
+}
+
+const c = {
+    "+1": 0,
+    [+1]: 0 // Duplicate
+}