fix(51077): skip insertText for jsx attribute with existing initializer (#51093)

Author: a-tarasyuk

src/services/completions.ts

@@ -1392,7 +1392,9 @@ function createCompletionEntry(
         sortText = SortText.SortBelow(sortText);
     }
 
-    if (isJsxIdentifierExpected && !isRightOfOpenTag && preferences.includeCompletionsWithSnippetText && preferences.jsxAttributeCompletionStyle && preferences.jsxAttributeCompletionStyle !== "none") {
+    if (isJsxIdentifierExpected && !isRightOfOpenTag
+        && preferences.includeCompletionsWithSnippetText && preferences.jsxAttributeCompletionStyle
+        && preferences.jsxAttributeCompletionStyle !== "none" && !(isJsxAttribute(location.parent) && location.parent.initializer)) {
         let useBraces = preferences.jsxAttributeCompletionStyle === "braces";
         const type = typeChecker.getTypeOfSymbolAtLocation(symbol, location);
 

tests/cases/fourslash/jsxTagNameCompletionWithExistingJsxInitializer.ts

@@ -0,0 +1,27 @@
+/// <reference path="fourslash.ts" />
+
+// @filename: /foo.tsx
+////declare namespace JSX {
+////    interface Element { }
+////    interface IntrinsicElements {
+////        foo: {
+////            className: string;
+////        }
+////    }
+////}
+////<foo cl/**/={""} />
+
+verify.completions({
+    marker: "",
+    includes: {
+        name: "className",
+        text: "(property) className: string",
+        insertText: undefined,
+        isSnippet: undefined,
+    },
+    preferences: {
+        jsxAttributeCompletionStyle: "braces",
+        includeCompletionsWithSnippetText: true,
+        includeCompletionsWithInsertText: true,
+    },
+})