Ensure that getProgramDiagnostic is included everywhere that getCompilerOptionsDiagnostic is

Author: orta

src/harness/client.ts

@@ -392,6 +392,10 @@ namespace ts.server {
             });
         }
 
+        getProgramDiagnostics(): Diagnostic[] {
+            return this.getCompilerOptionsDiagnostics();
+        }
+
         getCompilerOptionsDiagnostics(): Diagnostic[] {
             return notImplemented();
         }

src/harness/harnessLanguageService.ts

@@ -445,6 +445,9 @@ namespace Harness.LanguageService {
         getCompilerOptionsDiagnostics(): ts.Diagnostic[] {
             return unwrapJSONCallResult(this.shim.getCompilerOptionsDiagnostics());
         }
+        getProgramDiagnostics(): ts.Diagnostic[] {
+            return this.getCompilerOptionsDiagnostics();
+        }
         getSyntacticClassifications(fileName: string, span: ts.TextSpan): ts.ClassifiedSpan[] {
             return unwrapJSONCallResult(this.shim.getSyntacticClassifications(fileName, span.start, span.length));
         }
@@ -520,7 +523,6 @@ namespace Harness.LanguageService {
         getNavigationTree(fileName: string): ts.NavigationTree {
             return unwrapJSONCallResult(this.shim.getNavigationTree(fileName));
         }
-
         getOutliningSpans(fileName: string): ts.OutliningSpan[] {
             return unwrapJSONCallResult(this.shim.getOutliningSpans(fileName));
         }

src/services/shims.ts

@@ -143,6 +143,7 @@ namespace ts {
         getSemanticDiagnostics(fileName: string): string;
         getSuggestionDiagnostics(fileName: string): string;
         getCompilerOptionsDiagnostics(): string;
+        getProgramDiagnostics(): string;
 
         getSyntacticClassifications(fileName: string, start: number, length: number): string;
         getSemanticClassifications(fileName: string, start: number, length: number): string;
@@ -734,6 +735,10 @@ namespace ts {
             return this.forwardJSONCall(`getSuggestionDiagnostics('${fileName}')`, () => this.realizeDiagnostics(this.languageService.getSuggestionDiagnostics(fileName)));
         }
 
+        public getProgramDiagnostics(): string {
+            return this.getCompilerOptionsDiagnostics();
+        }
+
         public getCompilerOptionsDiagnostics(): string {
             return this.forwardJSONCall(
                 "getCompilerOptionsDiagnostics()",

tests/cases/compiler/limitRecursionInIntersectionsWithThisProperties.ts

@@ -0,0 +1,14 @@
+// 35804
+
+interface ITreeItem {    
+  Parent?: this;
+}
+
+type NodeWithId = ITreeItem & { Id?: number };
+
+function getMaxId(items: NodeWithId[]) {
+}
+
+const nodes = [] as ITreeItem[];
+getMaxId(nodes);
+