Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document const enum pitfalls and workarounds #2127

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Document const enum pitfalls and workarounds #2127

merged 1 commit into from
Jan 12, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Nov 5, 2021

Attempt to recycle these learnings microsoft/TypeScript#37774 (comment) into documentation, to address microsoft/TypeScript#37179 (comment).

Fixes microsoft/TypeScript#37179 (comment)

orta
orta approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree this is good - I just will find some time to go over the words a bit and tweak but thanks this is a solid idea.

@jablko
Copy link
Contributor Author

jablko commented Nov 13, 2021

👍 Thanks!

@orta
Copy link
Contributor

orta commented Jan 12, 2022

I think we should take this pretty much as is, it feels solid to me - thanks!

@orta orta merged commit fac856d into microsoft:v2 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pain points with const enum
2 participants
@jablko @orta