Remove clone node overrides - #842
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoMar 25, 2020
Merged
Conversation
They make tablesorter, a jquery dependent, invariant in a complex way that I have yet to figure out. I'm reverting this change for 3.9 until I have time to see how likely other projects are to encounter the problem.
Nathan Shively-Sanders (sandersn)
deleted the
remove-cloneNode-overrides
branch
March 25, 2020 00:23
Nathan Shively-Sanders (sandersn)
added a commit
to microsoft/TypeScript
that referenced
this pull request
Mar 25, 2020
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 25, 2020
Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842
Nathan Shively-Sanders (sandersn)
added a commit
to microsoft/TypeScript
that referenced
this pull request
Mar 25, 2020
* Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842 * update baselines
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 25, 2020
Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842 ace6d68 update baselines
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
to microsoft/TypeScript
that referenced
this pull request
Mar 25, 2020
* Cherry-pick PR #37568 into release-3.9 Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842 ace6d68 update baselines * Update LKG Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com> Co-authored-by: typescript-bot <typescript@microsoft.com>
|
Sorry if spam. Just leaving a more explicit paper trail for anybody trying to track down the history: This change reverts #811. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They make
@types/tablesorter, a jquery dependent, invariant in a complex way that I have yet to figure out. I'm reverting this change for 3.9 until Ihave time to see how likely other projects are to encounter the problem.
Orta Therox (@orta) Daniel Rosenwasser (@DanielRosenwasser)