Skip to content

fix CustomElementConstructor - https://github.com/microsoft/TypeScript/issues/36965 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix CustomElementConstructor - https://github.com/microsoft/TypeScript/issues/36965 #833

wants to merge 2 commits into from

Conversation

jogibear9988
Copy link

@jogibear9988 jogibear9988 commented Mar 15, 2020 •
edited
Loading

@jogibear9988 jogibear9988 requested a review from sandersn as a code owner March 15, 2020 19:38
@jogibear9988 jogibear9988 changed the title fix CustomElementConstructor - #36965 fix CustomElementConstructor - https://github.com/microsoft/TypeScript/issues/36965 Mar 15, 2020
sandersn
sandersn approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but doesn't update baselines -- we want to take this for 3.9 since it's a 3.8 regression, so I'll update the baselines.

@msftclas
Copy link

msftclas commented Mar 17, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

orta added a commit that referenced this pull request Mar 20, 2020
@orta
Recrate #833 from scratch to avoid CLA issues
3165f70
orta pushed a commit that referenced this pull request Mar 20, 2020
Merge pull request #838 from microsoft/recreate_833
6e020e5 
Recrate #833 from scratch to avoid CLA issues
@orta
Copy link
Contributor

orta commented Mar 20, 2020

Deprecated by #838

@orta orta closed this Mar 20, 2020
@jogibear9988 jogibear9988 deleted the patch-1 branch March 20, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression from 3.7.5 - Custom elements doesn't allow constructor parameters
4 participants
@jogibear9988 @msftclas @orta @sandersn