Skip to content

Commit d94a4a0

Browse files
author
falsandtru
committed
Fix ParentNode interface
1 parent ebd3e56 commit d94a4a0

File tree

4 files changed

+38
-16
lines changed

4 files changed

+38
-16
lines changed

baselines/dom.generated.d.ts

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2739,7 +2739,7 @@ interface DocumentEventMap extends GlobalEventHandlersEventMap {
27392739
"webkitfullscreenerror": Event;
27402740
}
27412741

2742-
interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEvent, ParentNode, DocumentOrShadowRoot {
2742+
interface Document extends Node, GlobalEventHandlers, DocumentEvent, ParentNode, DocumentOrShadowRoot {
27432743
/**
27442744
* Sets or gets the URL for the current document.
27452745
*/
@@ -3448,7 +3448,7 @@ declare var Document: {
34483448
new(): Document;
34493449
}
34503450

3451-
interface DocumentFragment extends Node, NodeSelector, ParentNode {
3451+
interface DocumentFragment extends Node {
34523452
}
34533453

34543454
declare var DocumentFragment: {
@@ -3545,7 +3545,7 @@ interface ElementEventMap extends GlobalEventHandlersEventMap {
35453545
"webkitfullscreenerror": Event;
35463546
}
35473547

3548-
interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelector, ChildNode, ParentNode {
3548+
interface Element extends Node, GlobalEventHandlers, ElementTraversal, ChildNode, ParentNode {
35493549
readonly classList: DOMTokenList;
35503550
className: string;
35513551
readonly clientHeight: number;
@@ -13718,13 +13718,6 @@ interface NavigatorUserMedia {
1371813718
getUserMedia(constraints: MediaStreamConstraints, successCallback: NavigatorUserMediaSuccessCallback, errorCallback: NavigatorUserMediaErrorCallback): void;
1371913719
}
1372013720

13721-
interface NodeSelector {
13722-
querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null;
13723-
querySelector(selectors: string): Element | null;
13724-
querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K];
13725-
querySelectorAll(selectors: string): NodeListOf<Element>;
13726-
}
13727-
1372813721
interface RandomSource {
1372913722
getRandomValues(array: ArrayBufferView): ArrayBufferView;
1373013723
}
@@ -14099,6 +14092,10 @@ interface ParentNode {
1409914092
readonly firstElementChild: Element | null;
1410014093
readonly lastElementChild: Element | null;
1410114094
readonly childElementCount: number;
14095+
querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null;
14096+
querySelector(selectors: string): Element | null;
14097+
querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K];
14098+
querySelectorAll(selectors: string): NodeListOf<Element>;
1410214099
}
1410314100

1410414101
interface DocumentOrShadowRoot {

inputfiles/addedTypes.json

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,6 +1201,22 @@
12011201
"readonly": true,
12021202
"type": "number"
12031203
}
1204+
],
1205+
"methods": [
1206+
{
1207+
"name": "querySelector",
1208+
"signatures": [
1209+
"querySelector<K extends keyof ElementTagNameMap>(selectors: K): ElementTagNameMap[K] | null",
1210+
"querySelector(selectors: string): Element | null"
1211+
]
1212+
},
1213+
{
1214+
"name": "querySelectorAll",
1215+
"signatures": [
1216+
"querySelectorAll<K extends keyof ElementListTagNameMap>(selectors: K): ElementListTagNameMap[K]",
1217+
"querySelectorAll(selectors: string): NodeListOf<Element>"
1218+
]
1219+
}
12041220
]
12051221
},
12061222
{
@@ -1213,11 +1229,6 @@
12131229
"baseInterface": "ParentNode",
12141230
"interface": "Document"
12151231
},
1216-
{
1217-
"kind": "extends",
1218-
"baseInterface": "ParentNode",
1219-
"interface": "DocumentFragment"
1220-
},
12211232
{
12221233
"kind": "typedef",
12231234
"name": "ScrollRestoration",

inputfiles/overridingTypes.json

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,7 @@
950950
},
951951
{
952952
"kind": "extends",
953-
"baseInterface": "Node, GlobalEventHandlers, NodeSelector, DocumentEvent, ParentNode, DocumentOrShadowRoot",
953+
"baseInterface": "Node, GlobalEventHandlers, DocumentEvent, ParentNode, DocumentOrShadowRoot",
954954
"interface": "Document"
955955
},
956956
{
@@ -991,5 +991,15 @@
991991
"interface": "DOMImplementation",
992992
"name": "hasFeature",
993993
"signatures": ["hasFeature(feature: string | null, version: string | null): boolean"]
994+
},
995+
{
996+
"kind": "extends",
997+
"baseInterface": "Node",
998+
"interface": "DocumentFragment"
999+
},
1000+
{
1001+
"kind": "extends",
1002+
"baseInterface": "Node, GlobalEventHandlers, ElementTraversal, ChildNode, ParentNode",
1003+
"interface": "Element"
9941004
}
9951005
]

inputfiles/removedTypes.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,9 @@
7777
{
7878
"kind": "typedef",
7979
"name": "JSON"
80+
},
81+
{
82+
"kind": "interface",
83+
"name": "NodeSelector"
8084
}
8185
]

0 commit comments

Comments
 (0)