Make <xatomic.h>, <xbit_ops.h>, and <xerrc.h> core headers (#3116)

Author: frederick-vs-ja

stl/inc/xatomic.h

@@ -1,12 +1,12 @@
-// xatomic.h internal header
+// xatomic.h internal header (core)
 
 // Copyright (c) Microsoft Corporation.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 #pragma once
 #ifndef _XATOMIC_H
 #define _XATOMIC_H
-#include <yvals.h>
+#include <yvals_core.h>
 #if _STL_COMPILER_PREPROCESSOR
 
 #include <intrin0.h>

stl/inc/xbit_ops.h

@@ -1,12 +1,12 @@
-// xbit_ops.h internal header
+// xbit_ops.h internal header (core)
 
 // Copyright (c) Microsoft Corporation.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 #pragma once
 #ifndef _XBIT_OPS_H
 #define _XBIT_OPS_H
-#include <yvals.h>
+#include <yvals_core.h>
 #if _STL_COMPILER_PREPROCESSOR
 
 #include <cstdint>

stl/inc/xerrc.h

@@ -1,12 +1,12 @@
-// xerrc.h internal header
+// xerrc.h internal header (core)
 
 // Copyright (c) Microsoft Corporation.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 #pragma once
 #ifndef _XERRC_H
 #define _XERRC_H
-#include <yvals.h>
+#include <yvals_core.h>
 #if _STL_COMPILER_PREPROCESSOR
 
 #pragma pack(push, _CRT_PACKING)

tests/std/tests/GH_001411_core_headers/test.cpp

@@ -6,6 +6,24 @@
 
 #include <__msvc_all_public_headers.hpp>
 
+// Also test GH-3103 "<xatomic.h>: Investigate making this a core header" and other internal core headers
+#include <__msvc_int128.hpp>
+#include <__msvc_system_error_abi.hpp>
+#include <__msvc_xlocinfo_types.hpp>
+#include <xatomic.h>
+#include <xbit_ops.h>
+#include <xerrc.h>
+
+#if _HAS_CXX17
+#include <xfilesystem_abi.h>
+#endif // _HAS_CXX17
+
+// <__msvc_iter_core.hpp> is included by <tuple>
+// <xkeycheck.h> should not be included outside of <yvals_core.h>
+// <xstddef> is included by <type_traits>
+// <xtr1common> is included by <cstddef>
+// <yvals_core.h> is included by every public core header
+
 #ifdef _YVALS
 #error Core headers should not include <yvals.h>.
 #endif