Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard Manager]: 'Remap a key' Dialog is not getting closed using 'ESC' key. #13380

Open
1 task
DhananjaySaini007 opened this issue Sep 23, 2021 · 4 comments
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working

Comments

@DhananjaySaini007
Copy link

Microsoft PowerToys version

0.45.0

Running as admin

  • Yes

Area(s) with issue?

Keyboard Manager

Steps to reproduce

Steps to reproduce
Test Environment:
OS: Windows 11 Version Dev
App version: 0.45.0
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Repro Steps:

  1. Launch 'PowerToys' application.
  2. In General tab, navigate to 'Keyboard Manager’ button and activate.
  3. Navigate to ‘Remap a key’ and activate it using enter/Space key.
  4. Now, Remap a key dialog box will appear.
  5.  Press 'ESC' key and Observe the issue.
    

Note :
Same issue repro with Remap a shortcut.

User Impact: -> Priority 2
Keyboard user will face issue while navigating the app.

Guidelines Reference:-
https://www.w3.org/TR/WCAG21/#multiple-ways

Attachments:

Powertoys-.Remap.a.key.Dialog.is.not.getting.closed.using.ESC.key.mp4

PowerToys - 'Remap a key' Dialog is not getting closed using 'ESC' key

PowerToys - 'Remap a Shortcut' Dialog is not getting closed using 'ESC' key

✔️ Expected Behavior

When 'Esc' key pressed the 'Remap a key' dialog should get closed.

❌ Actual Behavior

When 'Esc' key pressed on the 'Remap a key' dialog is not getting closed.

Other Software

No response

@DhananjaySaini007 DhananjaySaini007 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 23, 2021
@Priyanshu073 Priyanshu073 added A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft labels Sep 23, 2021
@niels9001
Copy link
Contributor

This is considered to be launching of a new application windows - not a dialog. Therefore, it should not close when pressing ESC?

cc @crutkas

@niels9001 niels9001 removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 30, 2021
@crutkas
Copy link
Member

crutkas commented Sep 30, 2021

While under the hood, yes but i think the accessibility team is saying from an end user experience, the OK / cancel makes this basically into a dialog.

I think this is fair feedback.

@niels9001
Copy link
Contributor

@crutkas Hmm true. It should be redesigned altogether. There are tens of accessibility issues with the current implementation.

@WSeneca WSeneca added the Area-Accessibility Issues related to accessibility label Dec 2, 2022
@Priyanshu073
Copy link

This issue is still repro on version 0.76.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

5 participants