Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones Editor - Edit layout]: Text 'Edit layout' of the edit layout dialog should be defined as heading. #10830

Closed
1 task
Priyanka-Chauhan123 opened this issue Apr 20, 2021 · 5 comments
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-FancyZones Refers to the FancyZones PowerToy

Comments

@Priyanka-Chauhan123
Copy link

Priyanka-Chauhan123 commented Apr 20, 2021

Microsoft PowerToys version

"0.35.0"

Running as admin

  • Yes

Area(s) with issue?

FancyZones Editor

Steps to reproduce

Test Environment:
OS: Windows 10 Build 21354.1
App version: 0.35.0
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Repro Steps

  1. Launch 'PowerToys' application.
  2. Turn on the 'Narrator'.
  3. Application will get open with default list item 'General' selected.
  4. Navigate to 'FancyZones' at the left side of the pane and activate it.
  5. Now navigate to 'Launch layout editor button and activate it.
  6. FancyZones editor window will get open.
  7. Navigate to 'Edit layout' button of any layout (say Grid) and activate it.
  8. Turn on the scan mode of the narrator using 'Caps + Space'.
  9. Navigate in the heading mode using 'Caps + Page up/Page down' arrow key.
  10. Now, Press 'Caps + Right/Left arrow key' to check the headings defined on the page.
  11. Observe the issue.

User Impact: Priority-2
If headings are not clear and descriptive, it would be difficult for screen reader dependent users to find the information they seek , and cannot understand the relationships between different parts of the content.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B9EBE78B9-6AEE-4CCA-908B-52A214B437A8%7D&file=MAS%202.4.6%20%E2%80%93%20Headings%20and%20Labels.docx&wdLOR=c8BB700E9-6F3C-492A-8874-3CACAD96EEB9&action=default&mobileredirect=true&cid=5a634e83-ba04-4312-8068-478ab13e0e9a

Note: Same issue repro for 'Choose layout type' dialog.

MAS2.4.6_Edt layout dialog_Edit layout should be defined as heading.zip

MAS2 4 6_UIA_Edit layout - heading

MAS2 4 6_UIA_Choose layout type text - heading

✔️ Expected Behavior

Text 'Edit layout' of the edit layout dialog should be defined as heading.

❌ Actual Behavior

Text 'Edit layout' of the edit layout dialog is not defined as heading.

Other Software

No response

@Priyanka-Chauhan123 Priyanka-Chauhan123 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 20, 2021
@crutkas crutkas added the A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft label Apr 20, 2021
@niels9001 niels9001 added Priority-2 Bug that is medium priority FancyZones-Editor Issue revolving the FancyZone Editor and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 21, 2021
@niels9001
Copy link
Contributor

niels9001 commented Jun 5, 2021

@crutkas I believe WPF does not support HeadingLevels - only UWP does.

What does that mean for this issue? Set as Blocked for WinUI 3?

More info:
dotnet/wpf#1825

@ghost ghost added A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines labels Jul 13, 2021
@niels9001
Copy link
Contributor

There's a PR that adds Heading support in WPF: dotnet/wpf#4751

@niels9001
Copy link
Contributor

@dedavis6797 dotnet/wpf#4751 seems to be merged and part of .NET 5.0.8. That will allow us to set the Heading of objects.

@Aaron-Junker Aaron-Junker added the Product-FancyZones Refers to the FancyZones PowerToy label Jan 13, 2022
@WSeneca WSeneca added the Area-Accessibility Issues related to accessibility label Dec 2, 2022
@Anshi0420 Anshi0420 added A11yUsable Accessibility Team tag - Usable and removed A11ySev3 Accessibility team tag - P3 items labels Mar 28, 2023
@Anshi0420
Copy link

Changing the severity as usable as it has low user impact.

@Suriya617 Suriya617 added A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines and removed A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines A11yUsable Accessibility Team tag - Usable labels Mar 30, 2023
@Priyanshu073
Copy link

Closing this bug and tracking it with a new ID mentioned above to track it with higher severity issue as the bug has high user impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Development

No branches or pull requests

8 participants