-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functionality for Project Cards #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, you're rocking it with contributions. Thanks so much. 🎆
I do have some feedback for you to consider with this change. Again, thanks so much.
Can you resolve the merge conflict now in the .psd1 again (since a new conflict occurred now that the Columns work was merged in). Once resolved and I've verified a successful test pass, I'll get this one merged in, along with your documentation update. Then I'll rev the version number and publish out a new version. Thanks for all your help! |
After your merges, the psd1 is in that bad state again (every line changed). Can you please try the same fix again as you did on the other PR? |
Alright - should be good now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks.
This is now available publicly in 0.12.0. Thanks so much for your contribution. 🎆 |
FYI @jpomfret - In my upcoming pipeline enabling change, I'm going to be changing the signature of |
Makes sense to me, thanks for the heads up |
Hey @HowardWolosky - has your change for ContentId --> IssueId/PullRequesetId made it to the PowerShell Gallery? Downloaded 0.14 today but it doesn't have this change in, even though I see it in this repo for version 0.14. (Am finally finishing up a blog post on creating project/issue/cards with PowerShell so wanted to make sure I was accurate 😄) |
Hi @jpomfret -- 0.14.0 is from 5/30/2020. There are tags in The PR pipeline is just about flushed through of all the breaking changes. I can probably start working on the CHANGELOG update today so that I can release 0.15.0 within the next day or two. |
@jpomfret -- Decided to do a little more work in the module to take advantage of all the breaking changes in the coming release. I think As an FYI, an additional breaking change for your changes is that the |
Sounds good! Sorry for the slow reply, looking forward to the new release. |
Covers:
The tests don't run successfully without the Project code from PR #160, if you want I can rebase this branch with master once/if the core project code gets merged in?