Addition of Aletheia connector #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sriyen-msft
previously approved these changes
Mar 11, 2021
dougelliott
suggested changes
Mar 11, 2021
| "description": "Aletheia is an online web service providing financial data through an easily accessible HTTP REST API. Access stock data, SEC filings, Insider Trades, earnings calls, and more.", | ||
| "version": "1.0", | ||
| "contact": { | ||
| "name": "Tim Hanewich", |
There was a problem hiding this comment.
We usually advocate for the contact metadata to not contain PII, as this information will be user-facing. Any chance this could instead point to a general support email within the Aletheia domain that you have? And the name could then be changed to something like Aletheia Support.
There was a problem hiding this comment.
Doug - thanks for the feedback. I just pushed an update to these details. Let me know if I am missing anything else. Thank you.
dougelliott
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following conditions for your PR.
apiDefinition.swagger.jsonis validated usingpaconn validatecommand.apiProperties.jsonhas a valid brand color. Invalid brand colors are#007ee5and#ffffff.