Skip to content

Conversation

@andrzejwp
Copy link
Contributor

This PR adds the ability to integrate Logic Apps with the Flotiq headless CMS.

@andrzejwp andrzejwp requested a review from a team as a code owner February 23, 2021 16:42
@ghost
Copy link

ghost commented Feb 23, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@sriyen-msft sriyen-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzejwp Please find below warnings we noticed in the swagger validation log which are worth to consider.

The dynamic operation expects a property on the specified path 'schemaDefinition/allOf/1/properties' which should be defined in the successful response of the invoked operation 'GetContentTypeSchema'. ValuePath: /definitions/CTD/x-ms-dynamic-schema/value-path The dynamic operation expects a property on the specified path 'schemaDefinition/allOf/1' which should be defined in the successful response of the invoked operation 'GetContentTypeSchema'. ValuePath: /definitions/CTD/x-ms-dynamic-properties/itemValuePath The dynamic operation expects a property on the specified path 'schemaDefinition' which should be defined in the successful response of the invoked operation 'GetContentTypeSchema'. ValuePath: /paths/~1api~1v1~1content~1{contentTypeId}/post/parameters/1/schema/allOf/1/x-ms-dynamic-properties/itemValuePath The dynamic operation expects an array on the specified path 'data' which should be defined in the successful response of the invoked operation 'GetCTD'. ValuePath: /paths/~1api~1v1~1content~1{contentTypeId}/post/parameters/0/x-ms-dynamic-values/value-collection

@andrzejwp
Copy link
Contributor Author

andrzejwp commented Feb 24, 2021

@sriyen-msft thanks for the comments and suggestions. I addressed them in the recent commit. Regarding the warnings - they are, unfortunately, impossible to fix at this point because:

  1. Power platform does not support OpenAPI composition (allOf keyword)
  2. Flotiq uses composition in the Content Type schema definition

so we will have to live with this until either of these gets resolved ;)
We have tested this, and despite these warnings, the integration works as expected.

@dougelliott dougelliott merged commit a7b6594 into microsoft:dev Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants