Data247logic #584

Data247logic · 2020-11-26T23:10:54Z

Please check the following conditions for your PR.

apiDefinition.swagger.json is validated using paconn validate command.
apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

) * Update apiDefinition.swagger.json * Add files via upload * update readme * Update Get User Info Action and apiProperties file

* Create IN-D KYC India * Delete IN-D KYC India * Create apiDefinition.swagger.json * Add files via upload * Create README.MD * Update README.MD * Delete README.MD * Delete apiDefinition.swagger.json * Delete apiProperties.json * Create IN-D Insurance * Delete IN-D Insurance * Create IN-D Insurance * Delete IN-D Insurance * Create Readme.md * Add files via upload * Add files via upload * Delete Readme.md * Delete apiDefinition.swagger.json * Delete apiProperties.json * Create Readme.md * Add files via upload * Add files via upload

ghost · 2020-11-26T23:11:08Z

All CLA requirements met.

dougelliott

In addition to the comments, you can also remove the icon.png and settings.json file from this PR, as they don't need t be open sourced. The icon will be provided during the submission process within ISV Studio.

certified-connectors/Data247logic/apiDefinition.swagger.json

certified-connectors/Data247logic/apiProperties.json

certified-connectors/Data247logic/README.md

certified-connectors/Data247logic/apiDefinition.swagger.json

Data247logic · 2020-12-23T08:48:22Z

Hi Doug, Sorry for the delay, I was busy with other things, I have done all the changes in suggested by you and your colleague. Can you please review and let me know what is next step to proceed further. waiting for your reply... Regards, M.i

…

On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA> .

sriyen-msft · 2020-12-24T01:23:26Z

Hi Doug, Sorry for the delay, I was busy with other things, I have done all the changes in suggested by you and your colleague. Can you please review and let me know what is next step to proceed further. waiting for your reply... Regards, M.i
…
On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott @.> wrote: @.* approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA .

@Data247logic There seems few comments need to be fixed, Can you please resolve the comments (Click on "resolve conversation") you have already fixed.

Data247logic · 2021-01-03T19:37:24Z

Hi Doug, Sorry for bugging you, I am new to Git can you please provide me what other points are left to fix also how to find resolve button on comments. waiting for your reply... regards, M.i On Thu, Dec 24, 2020 at 6:53 AM Srikanth Yenagandhula < notifications@github.com> wrote:

…

Hi Doug, Sorry for the delay, I was busy with other things, I have done all the changes in suggested by you and your colleague. Can you please review and let me know what is next step to proceed further. waiting for your reply... Regards, M.i … <#m_1958340733201656667_> On Tue, Dec 22, 2020 at 9:39 AM Doug Elliott *@*.*> wrote: @.** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review) <#584 (review)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLGTDU5JTRTD67YGMR3IOTSWALXZANCNFSM4UEHR3ZA . There seems few comments need to be fixed, Can you please resolve the comments (Click on "resolve conversation") you have already fixed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDV3KPRKB3F3G5SRKXLSWKJZVANCNFSM4UEHR3ZA> .

dougelliott · 2021-01-06T05:25:39Z

@Data247logic I've gone ahead and resolved the comments that seem to have been addressed. So all the pending comments left by Srikanth and myself should be addressed in another commit. Please let us know if there are any questions about the feedback.

Data247logic · 2021-01-06T07:47:03Z

Hi Doug, All the comments are resolved and fixed, please review and let me know what will be the next step in connector release. when it will be released on the platform for users to use. waiting for your reply.. regards, M.I

…

On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott ***@***.***> wrote: @Data247logic <https://github.com/Data247logic> I've gone ahead and resolved the comments that seem to have been addressed. So all the pending comments left by Srikanth and myself should be addressed in another commit. Please let us know if there are any questions about the feedback. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA> .

Data247logic · 2021-01-11T20:11:21Z

Hi Doug, Did you get my previous email? can you please proceed further with the approval so that my connector can be online in the marketplace. waiting for your reply... regards, M.i On Wed, Jan 6, 2021 at 1:16 PM Mohammad Istiyaq <mohammad@logictree.com> wrote:

…

Hi Doug, All the comments are resolved and fixed, please review and let me know what will be the next step in connector release. when it will be released on the platform for users to use. waiting for your reply.. regards, M.I On Wed, Jan 6, 2021 at 10:55 AM Doug Elliott ***@***.***> wrote: > @Data247logic <https://github.com/Data247logic> I've gone ahead and > resolved the comments that seem to have been addressed. So all the pending > comments left by Srikanth and myself should be addressed in another commit. > Please let us know if there are any questions about the feedback. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#584 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ARLGTDTRKCNSK34WLCD6YNLSYPX6DANCNFSM4UEHR3ZA> > . >

dougelliott · 2021-01-14T03:51:40Z

@Data247logic I've already approved the PR, but it is now pending a review from my colleague, @sriyen-msft . He will provide another round of reviews on your changes soon, and will follow up with any further points of feedback.

sriyen-msft · 2021-01-14T23:30:24Z

certified-connectors/Data247logic/apiDefinition.swagger.json

+    "/v3.0/MT/": {
+      "get": {
+        "responses": {
+          "default": {


Please replace ALL the "default" responses with expected status codes, otherwise users may see errors about incorrect schema instead of real error responses from your service in OpenAPI mode.

Data247logic · 2021-01-19T11:06:33Z

Hi, I am not getting you, can you please give me one example so that i can fix it and finish this off. waiting for your reply... regards, M.i

…

On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula < ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In certified-connectors/Data247logic/apiDefinition.swagger.json <#584 (comment)> : > + "contact":{ + "name":"Data247 Support", + "url":"https://support.data247.com/" + } + }, + "host": "api.data247.com", + "basePath": "/", + "schemes": [ + "https" + ], + "paths": { + "/v3.0": {}, + "/v3.0/MT/": { + "get": { + "responses": { + "default": { Please replace *ALL* the "default" responses with expected status codes, otherwise users may see errors about incorrect schema instead of real error responses from your service in OpenAPI mode. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA> .

sriyen-msft · 2021-01-21T00:18:24Z

Hi, I am not getting you, can you please give me one example so that i can fix it and finish this off. waiting for your reply... regards, M.i
…
On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula < @.> wrote: @.* requested changes on this pull request. ------------------------------ In certified-connectors/Data247logic/apiDefinition.swagger.json <#584 (comment)> : > + "contact":{ + "name":"Data247 Support", + "url":"https://support.data247.com/" + } + }, + "host": "api.data247.com", + "basePath": "/", + "schemes": [ + "https" + ], + "paths": { + "/v3.0": {}, + "/v3.0/MT/": { + "get": { + "responses": { + "default": { Please replace ALL the "default" responses with expected status codes, otherwise users may see errors about incorrect schema instead of real error responses from your service in OpenAPI mode. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA .

Example - 365 Training

Data247logic · 2021-01-24T19:16:22Z

Hi Doug, I have updated the response, so please review and proceed further for approval so it will be live on Marketplace. waiting for your reply.... regards, M.i On Thu, Jan 21, 2021 at 5:48 AM Srikanth Yenagandhula < notifications@github.com> wrote:

…

Hi, I am not getting you, can you please give me one example so that i can fix it and finish this off. waiting for your reply... regards, M.i … <#m_2321327043759940115_> On Fri, Jan 15, 2021 at 5:41 AM Srikanth Yenagandhula < *@*.*> wrote: @.** requested changes on this pull request. ------------------------------ In certified-connectors/Data247logic/apiDefinition.swagger.json <#584 (comment) <#584 (comment)>> : > + "contact":{ + "name":"Data247 Support", + "url":" https://support.data247.com/" + } + }, + "host": "api.data247.com", + "basePath": "/", + "schemes": [ + "https" + ], + "paths": { + "/v3.0": {}, + "/v3.0/MT/": { + "get": { + "responses": { + "default": { Please replace *ALL* the "default" responses with expected status codes, otherwise users may see errors about incorrect schema instead of real error responses from your service in OpenAPI mode. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (review) <#584 (review)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLGTDTE5RZLSUWHZM2M2MDSZ6B2FANCNFSM4UEHR3ZA . Example - 365 Training <https://github.com/microsoft/PowerPlatformConnectors/blob/e953397c852a5afd6bc9f16740f5e7c958dec250/certified-connectors/365Training/apiDefinition.swagger.json#L44> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDWQZWJBSROQNUQ67D3S25XF7ANCNFSM4UEHR3ZA> .

dougelliott · 2021-01-27T04:01:39Z

@sriyen-msft Please re-review the changes that @Data247logic has made. Thanks!

sriyen-msft · 2021-01-28T02:26:16Z

@Data247logic Can you please remove extra files added to this PR

Data247logic · 2021-01-28T08:53:44Z

Hi Doug, I have removed icon.png, what else you need me to remove from PR ? please let me know as soon as possible so that we can finish this. waiting for your reply.... regards, M.i

…

On Thu, Jan 28, 2021 at 7:56 AM Srikanth Yenagandhula < ***@***.***> wrote: @Data247logic <https://github.com/Data247logic> Can you please remove extra files added to this PR [image: image] <https://user-images.githubusercontent.com/56276394/106081063-20d00d00-60cd-11eb-9580-8303baaef5de.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#584 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLGTDQBUHSKK3NO5QZ3YG3S4DDNLANCNFSM4UEHR3ZA> .

Data247logic · 2021-02-03T20:36:02Z

Hi Doug, Can you guys please close this and approve it? its been a very long time for approval, please approve and let me know what is next step. waiting for your reply... regards, M.i On Thu, Jan 28, 2021 at 2:23 PM Mohammad Istiyaq <mohammad@logictree.com> wrote:

…

Hi Doug, I have removed icon.png, what else you need me to remove from PR ? please let me know as soon as possible so that we can finish this. waiting for your reply.... regards, M.i On Thu, Jan 28, 2021 at 7:56 AM Srikanth Yenagandhula < ***@***.***> wrote: > @Data247logic <https://github.com/Data247logic> Can you please remove > extra files added to this PR > > [image: image] > <https://user-images.githubusercontent.com/56276394/106081063-20d00d00-60cd-11eb-9580-8303baaef5de.png> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#584 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ARLGTDQBUHSKK3NO5QZ3YG3S4DDNLANCNFSM4UEHR3ZA> > . >

sriyen-msft · 2021-02-04T20:04:19Z

@Data247logic I am not sure whether you are familiar or not with Github and PR pipeline, But please make sure that there is no "Swagger and Change Validation" errors in "checks" section of the PR whenever you push any commit. There are 10+ errors flagged, please fix them.

https://github.com/microsoft/PowerPlatformConnectors/pull/584/checks

##[error]The 'summary' value must end with alphanumeric character. ValuePath: /paths/~1v3.0~1MT~1/get/summary
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1MT~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CU~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CT~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1CI~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VE~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VA~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1VP~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AP~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AE~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1APR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AER~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AN~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AG~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AZ~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1AZR~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1GI~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1DC~1/get/responses/default
##[error]The 'default' response should not have schema definition. Schemas should be defined on expected responses only. ValuePath: /paths/~1v3.0~1TPC~1/get/responses/default

dougelliott · 2021-02-18T02:03:31Z

@Data247logic Checking in on the feedback that Srikanth provided above. Do you have any questions about that?

calvinleong and others added 14 commits November 5, 2020 11:58

Updated apiProperties.json and apiDefinition.swagger.json (microsoft#546

8039bfb

) * Update apiDefinition.swagger.json * Add files via upload * update readme * Update Get User Info Action and apiProperties file

Merge remote-tracking branch 'upstream/master' into dev

2487824

Create settings.json

440893b

Add files via upload

fa2df13

Create README.md

3696339

Update README.md

2f691f3

Create README.md

dc85e6d

Add files via upload

c78bb03

Delete README.md

b1bffc1

Delete apiDefinition.swagger.json

4127871

Delete apiProperties.json

26d9d4f

Delete icon.png

ebe9bda

Delete settings.json

394ae42

Data247logic requested a review from a team as a code owner November 26, 2020 23:10

dougelliott requested review from dougelliott and sriyen-msft December 1, 2020 00:20

dougelliott suggested changes Dec 1, 2020

View reviewed changes

certified-connectors/Data247logic/apiDefinition.swagger.json Outdated Show resolved Hide resolved

certified-connectors/Data247logic/apiDefinition.swagger.json Show resolved Hide resolved

certified-connectors/Data247logic/apiProperties.json Outdated Show resolved Hide resolved

sriyen-msft suggested changes Dec 2, 2020

View reviewed changes

Data247logic added 2 commits December 21, 2020 20:04

Update apiProperties.json

1904582

Update apiDefinition.swagger.json

0e8fcea

dougelliott requested review from dougelliott and sriyen-msft December 22, 2020 04:09

dougelliott previously approved these changes Dec 22, 2020

View reviewed changes

Update apiDefinition.swagger.json

3082cb3

Data247logic dismissed dougelliott’s stale review via 3082cb3 December 23, 2020 08:40

Update apiDefinition.swagger.json

bc257de

dougelliott previously approved these changes Dec 23, 2020

View reviewed changes

sriyen-msft suggested changes Jan 15, 2021

View reviewed changes

Update apiDefinition.swagger.json

e75fcad

Data247logic dismissed dougelliott’s stale review via e75fcad January 24, 2021 19:13

dougelliott requested a review from sriyen-msft January 27, 2021 04:00

Delete icon.png

b220bdd

Update apiDefinition.swagger.json

a5fd823

dougelliott approved these changes Feb 23, 2021

View reviewed changes

sriyen-msft approved these changes Feb 23, 2021

View reviewed changes

dougelliott merged commit eb3bccf into microsoft:dev Feb 24, 2021

Data247logic #584

Data247logic #584

Uh oh!

Conversation

Data247logic commented Nov 26, 2020

Uh oh!

ghost commented Nov 26, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougelliott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Data247logic commented Dec 23, 2020 via email

Uh oh!

sriyen-msft commented Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Data247logic commented Jan 3, 2021 via email

Uh oh!

dougelliott commented Jan 6, 2021

Uh oh!

Data247logic commented Jan 6, 2021 via email

Uh oh!

Data247logic commented Jan 11, 2021 via email

Uh oh!

dougelliott commented Jan 14, 2021

Uh oh!

sriyen-msft Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

Data247logic commented Jan 19, 2021 via email

Uh oh!

sriyen-msft commented Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Data247logic commented Jan 24, 2021 via email

Uh oh!

dougelliott commented Jan 27, 2021

Uh oh!

sriyen-msft commented Jan 28, 2021

Uh oh!

Data247logic commented Jan 28, 2021 via email

Uh oh!

Data247logic commented Feb 3, 2021 via email

Uh oh!

sriyen-msft commented Feb 4, 2021

Uh oh!

dougelliott commented Feb 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ghost commented Nov 26, 2020 •

edited by ghost

Loading

sriyen-msft commented Dec 24, 2020 •

edited

Loading

sriyen-msft commented Jan 21, 2021 •

edited

Loading