Skip to content

Tulip V1 #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 24, 2023
Merged

Tulip V1 #2316

merged 20 commits into from
Jan 24, 2023

Conversation

@eddya101
Copy link
Contributor

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • [YES ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • [ YES] I attest that the connector works and I verified by deploying and testing all the operations.
  • [ YES] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • [YES ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • [YES ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • [YES ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • [N/A ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • [YES ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • [ YES] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • [ Not required] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Power Automate Flows:
Screenshot 2023-01-19 at 16 47 26
Screenshot 2023-01-19 at 17 02 30
Screenshot 2023-01-19 at 16 57 30
Screenshot 2023-01-19 at 17 02 15

Flow Builder Testing:
make powerautomate com_environments_Default-95c64e18-c009-4e46-bdd9-ecfc373597e4_connections_available_custom_shared_tulip-20connector-20test-2016-20jan-5f3e1fcf7ed-e1d30bedbc48887d_edit_test

@eddya101 eddya101 requested a review from a team as a code owner January 19, 2023 17:10
@eddya101
Copy link
Contributor Author

Re API Properties Validator Fail - The "scriptOperations" property was added by customer connectors editing tool when I added the code. Anty advice how to fix this one?

Amjed-Ayoub
Amjed-Ayoub suggested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@Amjed-Ayoub Amjed-Ayoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddya101 thank you so much for your submission. The icon is not allowed in the open source repository. Please remove all your connector icons from this PR.
You can include the below files.

  1. apiDefinition.swagger.json
  2. apiProperties.json
  3. readme.md
  4. script.csx(optional in open source repository)

Thank you so much.

@Amjed-Ayoub Amjed-Ayoub added certified-connector Validation phase Connector is being validated by Microsoft. needs:partner-attention New For brand new connector submissions labels Jan 20, 2023
@Amjed-Ayoub
Copy link
Contributor

Re API Properties Validator Fail - The "scriptOperations" property was added by customer connectors editing tool when I added the code. Anty advice how to fix this one?

@eddya101 Please ignore this error.

@eddya101
Delete settings.json
dcd177d 
Not required in public repsository.
@eddya101
Delete icon.png
5f6bbe0 
Not required in open source repository
@eddya101
Fixing typos
4794d48
@eddya101
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Tulip Interfaces"]

@eddya101
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Tulip Interfaces"

@eddya101
Delete custom-connectors/Tulip directory
856be84 
Removed because it was in the wrong location
@eddya101
Copy link
Contributor Author

@Amjed-Ayoub Thanks for your review and feedback. All comments are now addressed. Let me know if there is anything else.

@eddya101
Delete icon.png
f309668 
Saved in wrong location
@eddya101 eddya101 requested a review from Amjed-Ayoub January 24, 2023 12:05
@Amjed-Ayoub
Copy link
Contributor

Hello @eddya101,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.

@Amjed-Ayoub Amjed-Ayoub merged commit dcf5679 into microsoft:dev Jan 24, 2023
@Amjed-Ayoub Amjed-Ayoub removed Validation phase Connector is being validated by Microsoft. needs:partner-attention New For brand new connector submissions labels Jan 24, 2023
lindarecfut pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Feb 14, 2023
@eddya101 @lindarecfut
Tulip V1 (microsoft#2316)
ac078b1 
* Create readme.md

* Create readme.md

* Create apiDefinition.swagger.json

* Create apiProperties.json

* Update readme.md

* Create script.csx

* Create settings.json

* Tulip R1

* New Icon File

* Updating icon

* Updating icon

* Add files via upload

* New Icon

* Add files via upload

* Delete settings.json

Not required in public repsository.

* Delete icon.png

Not required in open source repository

* Fixing typos

* Delete custom-connectors/Tulip directory

Removed because it was in the wrong location

* Delete icon.png

Saved in wrong location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Amjed-Ayoub Amjed-Ayoub Amjed-Ayoub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

certified-connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddya101 @Amjed-Ayoub