Rename _need_new_token to _should_refresh

Author: Abel Milash

src/PowerPlatform/Dataverse/aio/core/_async_auth.py

@@ -41,7 +41,7 @@ def __init__(self, credential: AsyncTokenCredential) -> None:
         self._lock = asyncio.Lock()
         self._refresh_jitter: int = 0
 
-    def _need_new_token(self) -> bool:
+    def _should_refresh(self) -> bool:
         """Return ``True`` when the cached token is missing or near expiry."""
         if self._token is None:
             return True
@@ -66,11 +66,11 @@ async def _acquire_token(self, scope: str) -> _TokenPair:
         :rtype: ~PowerPlatform.Dataverse.core._auth._TokenPair
         :raises ~azure.core.exceptions.ClientAuthenticationError: If token acquisition fails.
         """
-        if not self._need_new_token():
+        if not self._should_refresh():
             return _TokenPair(resource=scope, access_token=self._token.token)
         async with self._lock:
             # Double-check after acquiring lock — another coroutine may have refreshed.
-            if not self._need_new_token():
+            if not self._should_refresh():
                 return _TokenPair(resource=scope, access_token=self._token.token)
             try:
                 self._token = await self.credential.get_token(scope)

src/PowerPlatform/Dataverse/core/_auth.py

@@ -68,7 +68,7 @@ def __init__(self, credential: TokenCredential) -> None:
         self._lock = threading.Lock()
         self._refresh_jitter: int = 0
 
-    def _need_new_token(self) -> bool:
+    def _should_refresh(self) -> bool:
         """Return ``True`` when the cached token is missing or near expiry."""
         if self._token is None:
             return True
@@ -92,11 +92,11 @@ def _acquire_token(self, scope: str) -> _TokenPair:
         :rtype: ~PowerPlatform.Dataverse.core._auth._TokenPair
         :raises ~azure.core.exceptions.ClientAuthenticationError: If token acquisition fails.
         """
-        if not self._need_new_token():
+        if not self._should_refresh():
             return _TokenPair(resource=scope, access_token=self._token.token)
         with self._lock:
             # Double-check after acquiring lock — another thread may have refreshed.
-            if not self._need_new_token():
+            if not self._should_refresh():
                 return _TokenPair(resource=scope, access_token=self._token.token)
             try:
                 self._token = self.credential.get_token(scope)