Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document for supported runtime versions #1502

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add document for supported runtime versions #1502

merged 1 commit into from
Aug 4, 2022

Conversation

cormacpayne
Copy link
Contributor

Introduce a document that lists all runtime versions supported by Oryx to be present alongside the existing supportedPlatformVersions.md document that lists all platform versions in our storage account.

In the future, we should work to make this document dynamic like the platform versions document by pulling the versions from https://mcr.microsoft.com/v2/oryx/{platform}/tags/list

  • The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
    - [ ] Tests are included and/or updated for code changes.
    - [ ] Proper license headers are included in each file.

@cormacpayne cormacpayne requested a review from a team as a code owner August 3, 2022 20:50
StrawnSC added a commit to StrawnSC/azure-cli-extensions that referenced this pull request Aug 3, 2022
@StrawnSC
Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)
36451ef
pauld-msft
pauld-msft approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@pauld-msft pauld-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cormacpayne cormacpayne merged commit 7bf30b2 into main Aug 4, 2022
runefa added a commit to calvinsID/azure-cli-extensions that referenced this pull request Sep 15, 2022
@runefa @StrawnSC
Custom Domains on Managed Environments (#152)
3665e8b 
* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <strawnsc@gmail.com>

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Silas Strawn <strawnsc@gmail.com>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <strawnsc@gmail.com>
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
p-bouchon pushed a commit to p-bouchon/azure-cli-extensions that referenced this pull request Feb 24, 2023
@runefa @StrawnSC
Custom Domains on Managed Environments (Azure#152)
df599b0 
* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (Azure#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <strawnsc@gmail.com>

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Silas Strawn <strawnsc@gmail.com>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <strawnsc@gmail.com>
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
p-bouchon pushed a commit to p-bouchon/azure-cli-extensions that referenced this pull request Mar 20, 2023
@runefa @StrawnSC
Custom Domains on Managed Environments (Azure#152)
6f3fd5a 
* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (Azure#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <strawnsc@gmail.com>

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Silas Strawn <strawnsc@gmail.com>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <strawnsc@gmail.com>
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
yanzhudd pushed a commit to Azure/azure-cli-extensions that referenced this pull request Mar 31, 2023
@p-bouchon @StrawnSC
@runefa @Greedygre
Containerapp - add workload profile support and bump version to 11-01…
29df418 
…-preview (#6081)

* bump version

* Updated to preview api version and reran all tests. (#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <strawnsc@gmail.com>

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Silas Strawn <strawnsc@gmail.com>

* initial premium sku implementation

* bump version

* Custom Domains on Managed Environments (#152)

* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <strawnsc@gmail.com>

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Silas Strawn <strawnsc@gmail.com>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <strawnsc@gmail.com>
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>

* add/update premium sku features -- updates for api changes, up/containerapp create support, env update support, add help text

* workaround for updating workload profiles

* start testing; handle logging differently in update

* private preview

* automatically add WP to environment if needed

* unhardcode premium sku

* wlp changes

* fix auto lowercase

* change version

* change version

* merge conflicts

* fix wlp commands

* fix enable wlp

* change log analytics

* wlp updates

* wlp commands

* fix lowercase issues

* v1.0.4 add name and change type

* reset to v1.0.3

* v1.0.3 fix optional workload profile name

* update to 1.0.5, create containerapp with friendly name

* fix param names for 1.0.5

* change put to patch for update managed env

* 1.0.6, fix update container app and make wlp type optional

* fix other conflicts

* switch to 11-01-preview

* fix failing test scenario

* update workload profile tests

* add help for wlp commands

* cleanup some comments

* fix styling

* fix polling

* fix unintended rebasing change

* fix lint

* revert appLogsConfiguration in create_managedenvironment and fix pylint

* remove useless file and fix liner

* fix

* fix tags patch bug

* re run test

* change enable-workload-profiles

* remove usless test yml file

* revert poll change

* add preview flag

* fix preview

---------

Co-authored-by: Silas Strawn <strawnsc@gmail.com>
Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com>
Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: xinyu pang <1042945277@qq.com>
Co-authored-by: xinyu pang <46143499+Greedygre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauld-msft pauld-msft pauld-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cormacpayne @pauld-msft