Skip to content

Fetch annotations for paths ending with navigation properties using target path #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 24, 2024
Merged

Fetch annotations for paths ending with navigation properties using target path #509

merged 10 commits into from
Apr 24, 2024

Conversation

millicentachieng
Copy link
Member

@millicentachieng millicentachieng commented Mar 20, 2024 •
edited
Loading

Fixes #514

This PR:

  • Enables fetching of path descriptions, summary and external doc links using path as annotation target as the default for fetching annotations from CSDL
  • If annotations for path are not found, check annotations for type of last segment of the path e.g. navigation property, complex property etc
  • Tests to ensure that annotations with path as target are properly picked up

@millicentachieng millicentachieng force-pushed the miachien/path-annotations branch from 0c5275e to adf200f Compare March 27, 2024 12:14
@millicentachieng millicentachieng marked this pull request as ready for review March 27, 2024 12:15
andrueastman
andrueastman reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any hance you can double check the failing tests?

@millicentachieng millicentachieng force-pushed the miachien/path-annotations branch from fce3077 to 21e5d64 Compare April 4, 2024 10:46
andrueastman
andrueastman reviewed Apr 5, 2024
View reviewed changes
andrueastman
andrueastman previously approved these changes Apr 8, 2024
View reviewed changes
@millicentachieng millicentachieng linked an issue Apr 18, 2024 that may be closed by this pull request
Correctly generate annotations target path for paths that contain type casts #515
Closed
irvinesunday
irvinesunday previously approved these changes Apr 18, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
29 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarCloud

@millicentachieng millicentachieng merged commit f8cef27 into master Apr 24, 2024
@millicentachieng millicentachieng deleted the miachien/path-annotations branch April 24, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvinesunday irvinesunday irvinesunday approved these changes

@garethj-msft garethj-msft Awaiting requested review from garethj-msft

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@baywet baywet Awaiting requested review from baywet

@coseguera coseguera Awaiting requested review from coseguera

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly generate annotations target path for paths that contain type casts Prefer fetching descriptions and link annotations with path as target
4 participants
@millicentachieng @garethj-msft @andrueastman @irvinesunday