- adds unit test for complex property segment

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

Author: baywet

src/Microsoft.OpenApi.OData.Reader/Edm/ODataComplexPropertySegment.cs

@@ -20,9 +20,6 @@ public ODataComplexPropertySegment(IEdmStructuralProperty property)
         Property = property ?? throw Error.ArgumentNull(nameof(property));
     }
 
-    /// <inheritdoc />
-
-    public override IEdmEntityType EntityType => null;
     /// <inheritdoc />
     public override ODataSegmentKind Kind => ODataSegmentKind.ComplexProperty;
 

src/Microsoft.OpenApi.OData.Reader/PublicAPI.Unshipped.txt

@@ -95,7 +95,6 @@ Microsoft.OpenApi.OData.Edm.ODataTypeCastSegment.ODataTypeCastSegment(Microsoft.
 Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment
 Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.ODataComplexPropertySegment(Microsoft.OData.Edm.IEdmStructuralProperty property) -> void
 Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.Property.get -> Microsoft.OData.Edm.IEdmStructuralProperty
-override Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.EntityType.get -> Microsoft.OData.Edm.IEdmEntityType
 override Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.Kind.get -> Microsoft.OpenApi.OData.Edm.ODataSegmentKind
 override Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.Identifier.get -> string
 Microsoft.OpenApi.OData.Edm.ODataComplexPropertySegment.ComplexType.get -> Microsoft.OData.Edm.IEdmComplexType

test/Microsoft.OpenAPI.OData.Reader.Tests/Edm/ODataComplexPropertySegmentTests.cs

@@ -0,0 +1,62 @@
+// ------------------------------------------------------------
+//  Copyright (c) Microsoft Corporation.  All rights reserved.
+//  Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
+// ------------------------------------------------------------
+
+using System;
+using Microsoft.OData.Edm;
+using Xunit;
+
+namespace Microsoft.OpenApi.OData.Edm.Tests;
+public class ODataComplexPropertySegmentTests
+{
+    private readonly EdmEntityType _person;
+    private readonly EdmStructuralProperty _addressProperty;
+    private readonly EdmComplexType _addressComplexType;
+
+    public ODataComplexPropertySegmentTests()
+    {
+        _person = new EdmEntityType("NS", "Person");
+        _addressComplexType = new EdmComplexType("NS", "Address");
+        _addressComplexType.AddStructuralProperty("Street", EdmCoreModel.Instance.GetString(false));
+        _person.AddKeys(_person.AddStructuralProperty("Id", EdmCoreModel.Instance.GetString(false)));
+        _addressProperty = _person.AddStructuralProperty("HomeAddress", new EdmComplexTypeReference(_addressComplexType, false));
+    }
+
+    [Fact]
+    public void TypeCastSegmentConstructorThrowsArgumentNull()
+    {
+        Assert.Throws<ArgumentNullException>("property", () => new ODataComplexPropertySegment(null));
+    }
+
+    [Fact]
+    public void ComplexTypeReturnsPropertyComplexType()
+    {
+        // Arrange & Act
+        var segment = new ODataComplexPropertySegment(_addressProperty);
+
+        // Assert
+        Assert.Throws<NotImplementedException>(() => segment.EntityType);
+        Assert.Same(_addressComplexType, segment.ComplexType);
+    }
+
+    [Fact]
+    public void KindPropertyReturnsComplexPropertyEnumMember()
+    {
+        // Arrange & Act
+        var segment = new ODataComplexPropertySegment(_addressProperty);
+
+        // Assert
+        Assert.Equal(ODataSegmentKind.ComplexProperty, segment.Kind);
+    }
+
+    [Fact]
+    public void GetPathItemNameReturnsCorrectPropertyName()
+    {
+        // Arrange & Act
+        var segment = new ODataComplexPropertySegment(_addressProperty);
+
+        // Assert
+        Assert.Equal("HomeAddress", segment.GetPathItemName(new OpenApiConvertSettings()));
+    }
+}

test/Microsoft.OpenAPI.OData.Reader.Tests/Edm/ODataTypeCastSegmentTests.cs

@@ -11,13 +11,12 @@ namespace Microsoft.OpenApi.OData.Edm.Tests
 {
     public class ODataTypeCastSegmentTests
     {
-        private IEdmEntityType _person { get; }
+        private readonly EdmEntityType _person;
 
         public ODataTypeCastSegmentTests()
         {
-            var person = new EdmEntityType("NS", "Person");
-            person.AddKeys(person.AddStructuralProperty("Id", EdmCoreModel.Instance.GetString(false)));
-            _person = person;
+            _person = new EdmEntityType("NS", "Person");
+            _person.AddKeys(_person.AddStructuralProperty("Id", EdmCoreModel.Instance.GetString(false)));
         }
 
         [Fact]