Skip to content

Commit 23c693e

Browse files
committed
- addresses initial review comments
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
1 parent f5ca214 commit 23c693e

File tree

5 files changed

+19
-3
lines changed

5 files changed

+19
-3
lines changed

src/Microsoft.OpenApi.OData.Reader/Edm/ODataSegment.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ public string GetPathItemName(OpenApiConvertSettings settings)
109109
/// <param name="parameters">The existing parameters.</param>
110110
/// <returns>The path item name.</returns>
111111
public abstract string GetPathItemName(OpenApiConvertSettings settings, HashSet<string> parameters);
112+
112113
/// <summary>
113114
/// Provides any deprecation information for the segment.
114115
/// </summary>

src/Microsoft.OpenApi.OData.Reader/OpenApiExtensions/OpenApiDeprecationExtension.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
// ------------------------------------------------------------
2+
// Copyright (c) Microsoft Corporation. All rights reserved.
3+
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
4+
// ------------------------------------------------------------
5+
16
using System;
27
using System.Linq;
3-
using Microsoft.OpenApi;
48
using Microsoft.OpenApi.Interfaces;
59
using Microsoft.OpenApi.Writers;
610

test/Microsoft.OpenAPI.OData.Reader.Tests/OpenApiExtensions/OpenApiDeprecationExtensionTests.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
// ------------------------------------------------------------
2+
// Copyright (c) Microsoft Corporation. All rights reserved.
3+
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
4+
// ------------------------------------------------------------
5+
16
using System;
27
using System.IO;
3-
using Microsoft.OpenApi.Interfaces;
48
using Microsoft.OpenApi.Writers;
59
using Xunit;
610

@@ -17,11 +21,11 @@ public void ExtensionNameMatchesExpected()
1721
// Act
1822
string name = extension.Name;
1923
string expectedName = "x-ms-deprecation";
20-
Assert.Equal(expectedName, name);
2124

2225
// Assert
2326
Assert.Equal(expectedName, name);
2427
}
28+
2529
[Fact]
2630
public void WritesNothingWhenNoValues()
2731
{
@@ -41,6 +45,7 @@ public void WritesNothingWhenNoValues()
4145
Assert.Null(extension.Description);
4246
Assert.Empty(result);
4347
}
48+
4449
[Fact]
4550
public void WritesAllValues()
4651
{

test/Microsoft.OpenAPI.OData.Reader.Tests/Operation/EdmFunctionOperationHandlerTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public void SetsDeprecationInformation()
4242
var extension = operation.Extensions["x-ms-deprecation"];
4343
Assert.NotNull(extension);
4444
}
45+
4546
[Fact]
4647
public void DoesntSetDeprecationInformation()
4748
{

test/Microsoft.OpenAPI.OData.Reader.Tests/Vocabulary/Capabilities/DeprecatedRevisionTypeTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
// ------------------------------------------------------------
2+
// Copyright (c) Microsoft Corporation. All rights reserved.
3+
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
4+
// ------------------------------------------------------------
5+
16
using System;
27
using Microsoft.OData.Edm;
38
using Microsoft.OData.Edm.Vocabularies;

0 commit comments

Comments
 (0)