Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@kant
Copy link
Contributor

@kant kant commented Dec 27, 2019

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@najeeb-kazmi
Copy link
Member

Duplicate of #398

@najeeb-kazmi najeeb-kazmi marked this as a duplicate of #398 Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants