Fix incorrect check in PrefixColumnConcatenator core file.

microsoft · Nov 18, 2019 · 8afb279 · 8afb279
1 parent dc7b9fc
commit 8afb279
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/python/nimbusml/internal/core/preprocessing/schema/prefixcolumnconcatenator.py b/src/python/nimbusml/internal/core/preprocessing/schema/prefixcolumnconcatenator.py
@@ -85,7 +85,8 @@ def _get_node(self, **all_args):
 
         # validate output
         if output_columns is None:
-            output_columns = input_columns
+            raise ValueError(
+                "'None' output passed when it cannot be none.")
 
         if not isinstance(output_columns, list):
             raise ValueError(

diff --git a/src/python/tools/code_fixer.py b/src/python/tools/code_fixer.py
@@ -247,12 +247,18 @@ def fix_code(class_name, filename):
         all_args['output_for_sub_graph'] = {'Model' : \
 all_args['predictor_model']}"""
 
+prefixcolumnconcatenator_1 = "output_columns = input_columns"
+prefixcolumnconcatenator_1_correct = """raise ValueError(
+                "'None' output passed when it cannot be none.")"""
+
 signature_fixes_core = {
     'NGramFeaturizer': (textTransform_1, textTransform_1_correct),
     'ColumnConcatenator': [(concatColumns_1, concatColumns_1_correct)],
     'ColumnSelector': [(columnselector_1, columnselector_1_correct)],
     'OneVsRestClassifier': [
         (onevsrestclassifier_1, onevsrestclassifier_1_correct)],
+    'PrefixColumnConcatenator': (prefixcolumnconcatenator_1,
+                                 prefixcolumnconcatenator_1_correct)
 }