Parse 'Name' from gdb thread-info response #1482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDB thread-info packet combines the 'Name' and 'State' fields into a type of dictionary response. Even though the internal thread-info and wire protocol include separate and distinct fields, they get combined for some reason. This code parses the fields back out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDB thread-info packet combines the 'Name' and 'State' fields into a type of dictionary response. Even though the internal thread-info and wire protocol include separate and distinct fields, they get combined for some reason in the
-thread-inforesponse. You can see this in gdb's remote.c file, where it clearly has these separate fields.This code parses the fields back out, and makes it so the thread names are displayed properly in vscode.
Before
After