fix protobuf on vs build #1004
Merged
fix protobuf on vs build #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wxchan |
|
@wxchan please check the PR in your repo, it should pass the test now. |
* fix vs support * fix cmake
guolinke
approved these changes
Oct 26, 2017
wxchan
pushed a commit
to wxchan/LightGBM
that referenced
this pull request
Oct 26, 2017
* update atof * fix bug * fix tests. * fix bug * fix dtypes * fix categorical feature override * fix protobuf on vs build (microsoft#1004) * [optional] support protobuf * fix windows/LightGBM.vcxproj * add doc * fix doc * fix vs support (#2) * fix vs support * fix cmake * fix microsoft#1012 * [python] add network config api (microsoft#1019) * add network * update doc * add float tolerance in bin finder. * fix a bug * update tests * add double torelance on tree model * fix tests * simplify the double comparison * fix lightsvm zero base * move double tolerance to the bin finder. * fix pylint
guolinke
pushed a commit
that referenced
this pull request
Nov 9, 2017
* add init_score & test cpp and python result consistency * try fix common.h * Fix tests (#3) * update atof * fix bug * fix tests. * fix bug * fix dtypes * fix categorical feature override * fix protobuf on vs build (#1004) * [optional] support protobuf * fix windows/LightGBM.vcxproj * add doc * fix doc * fix vs support (#2) * fix vs support * fix cmake * fix #1012 * [python] add network config api (#1019) * add network * update doc * add float tolerance in bin finder. * fix a bug * update tests * add double torelance on tree model * fix tests * simplify the double comparison * fix lightsvm zero base * move double tolerance to the bin finder. * fix pylint * clean test.sh * add sklearn test * remove underline * clean codes * set random_state=None * add last line * fix doc * rename file * try fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guolinke can you help check whether it works now?