Migrate code to modern es6 syntax #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tricktreat
added a commit
that referenced
this pull request
Apr 14, 2023
This reverts commit 92c0d55.
tricktreat
added a commit
that referenced
this pull request
Apr 14, 2023
mGFROMTHE5031
pushed a commit
to mGFROMTHE5031/JARVIS
that referenced
this pull request
Apr 26, 2023
…to mGFROMTHE5031/issue143 * 'main' of https://github.com/mGFROMTHE5031/JARVIS.git: 634bc94 Revert "Migrate code to modern es6 syntax (microsoft#124)" (microsoft#147) # Conflicts: # .vscode/launch.json # .vscode/tasks.json # web/src/views/home.vue Signed-off-by: mindy gaines <mindy.gaines1@gmail.com>
Closed
mGFROMTHE5031
pushed a commit
to mGFROMTHE5031/JARVIS
that referenced
this pull request
May 3, 2023
…to mGFROMTHE5031/issue143 * 'main' of https://github.com/mGFROMTHE5031/JARVIS.git: 634bc94 Revert "Migrate code to modern es6 syntax (microsoft#124)" (microsoft#147) # Conflicts: # .vscode/launch.json # .vscode/tasks.json # web/src/views/home.vue Signed-off-by: mindy gaines <mindy.gaines1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the existing frontend code from using old
varsyntax toletandconstwhere appropriate. This change required a named variable change to enforce clarity and prevent duplicate variables.