Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

⚡️ 🚑 App Service Hotfix 2.0 #46

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

peterhessey
Copy link
Contributor

@peterhessey peterhessey commented Jun 29, 2022

Closes #45.

The previous Hotfix only addressed the surface-level issue of the az webapp up command not working. I naively did not properly manually test the deployed app, and turns out it was not running correctly at all: Azure App Services build their environments from the requirements.txt file (unsurprisingly) and as such the pip requirements must be placed into that file.

This PR includes changes to the environment locking script to seperate the conda and pip package versions between environment.yml and requirements.txt respectively, as well as pinning msrest==0.6.21 to circumvent certain incompatibilities as discussed in this thread.

Copy link

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what made you choose Bash for this script, instead of e.g. Python?

@peterhessey
Copy link
Contributor Author

Out of curiosity, what made you choose Bash for this script, instead of e.g. Python?

As soon as I need to start messing around with command line stuff such as running conda commands I usually just reach for bash as my go-to tool. No other reason though really, would have perhaps made more sense to do it in Python!

@peterhessey peterhessey merged commit 5de3842 into main Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env locking breaking app service still
3 participants