Skip to content

Bugfix: Set the status of devices to testing after the task is sure to run. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhou9584 merged 1 commit into from
Feb 15, 2023
Merged

Bugfix: Set the status of devices to testing after the task is sure to run. #273

zhou9584 merged 1 commit into from
Feb 15, 2023

Conversation

@zhou9584
Copy link
Contributor

@zhou9584 zhou9584 commented Feb 15, 2023 •
edited
Loading

if the group type is all and someone of them is under testing, the status of free device would be set as testing, but the task wouldn't start.
Repro steps:

  1. trigger first task with grouptype SINGLE
  2. when the first task is running, trigger second task with grouptype ALL
  3. the second task would be added to queue but the status of rest devices has been set to testing...

@zhou9584 zhou9584 merged commit 8f7d3c4 into main Feb 15, 2023
@zhou9584 zhou9584 deleted the zhoule/fixBug branch February 15, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@olivershen-wow olivershen-wow olivershen-wow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhou9584 @olivershen-wow