Merge main to preview #461
Conversation
* improvement & target on main branch * remove duplicated null check * remove redundant if * improvement * resolve comments * fix typo * update * use enum * Update testcases * fix bug * update * update the logic of FindWeeklyPreviousOccurrence * fix bug * add comments * update * fix bug & add testcases * update * update comment * test * update comments * update * update * add testcase * remove monthly/yearly recurrence pattern * do not mention monthly and yearly pattern * add more comments * update the algorithm to find weekly previous occurrence * update * fix typo * update * rename variable * cache added & do validation for only once * add comments * add more testcases * add more test * not include the end of a time window * move recurrence validation to RecurrenceValidator * README updated * update readme * update CalculateSurroundingOccurrences method * add CalculateClosestStart method * testcase updated * update * use ISystemClock for testing & add limit on time window duration * add testcase for timezone * update * update comments * change method type * remove unused reference * rename variable * remove used reference * remove empty lines
* Fix type in README * fix typo
* Moves cache busting and handles null * Adjusted null check * Remove formatting
… adjust wording (#448) * update README * remove unused reference
* replace init with set * revert to csharp 8.0 * add comment for LangVersion * update comment
* update readme * update * update * update title * emphasize the link * enumerate links * update
README.md
Outdated
| * [ASP.NET Core Web App (Razor Page)](./examples/RazorPages) | ||
| * [ASP.NET Core Web App (MVC)](./examples/FeatureFlagDemo) | ||
| * [Blazor Server App](./examples/BlazorServerApp) | ||
| * [Evaluation Data to Application Insights](./examples/EvaluationDataToApplicationInsights) |
There was a problem hiding this comment.
@zhenlan @jimmyca15 @rossgrambo Any suggestion for the name of this example project?
I think this example shows the following thing:
- How to use variant
- How to use telemetry and collect it to App Insights
- The general idea of how to do experimentation with FM lib and App Insights
The current name "EvaluationDataToApplicationInsights" doesn't mention variant or the idea of experimentation.
There was a problem hiding this comment.
Yeah good call. We don't have full experimentation so I don't think we can mention that...
Maybe just VariantsWithTelemetry?
There was a problem hiding this comment.
To me, it's an "ASP.NET Core Web App with Telemetry". People have to use variant feature flags to enable telemetry, so that's just implementation detail. Experimentation is a methodology to analyze telemetry. From the application perspective, it has no idea about the experimentation. So if you want to follow the naming of other examples, maybe "RazorPagesWithTelemetry"?
There was a problem hiding this comment.
I like Zhenlan's idea. I decide to land on "ASP.NET Core Web App with Feature Flag Telemetry"
* fix xunit1031 warning * resolve nullable warning * remove nullable * revert change to RazorPages project
Visible changes
#266 Recurring time window
#438 Bug fix for possible null iteration of feature definition
#441 Nuget Package metadata
#450 Stop using init-only setter
#459 README update