Update src/Microsoft.FeatureManagement/Telemetry/TelemetryEventHandler.cs

rossgrambo · samsadsam · web-flow · commit 94069992773c · 2024-10-23T11:35:34.000-07:00
Co-authored-by: Sami Sadfa &lt;71456174+samsadsam@users.noreply.github.com&gt;
diff --git a/src/Microsoft.FeatureManagement/Telemetry/TelemetryEventHandler.cs b/src/Microsoft.FeatureManagement/Telemetry/TelemetryEventHandler.cs
@@ -57,13 +57,7 @@ public static void HandleEvaluationEvent(EvaluationEvent evaluationEvent, ILogge
             if (evaluationEvent.VariantAssignmentReason == VariantAssignmentReason.DefaultWhenEnabled)
             {
                 // If the variant was assigned due to DefaultWhenEnabled, the percentage reflects the unallocated percentiles
-                double allocatedPercentage = 0;
-
-                if (evaluationEvent.FeatureDefinition.Allocation?.Percentile != null)
-                {
-                    allocatedPercentage += evaluationEvent.FeatureDefinition.Allocation.Percentile
-                        .Sum(p => p.To - p.From);
-                }
+double allocatedPercentage = evaluationEvent.FeatureDefinition.Allocation?.Percentile?.Sum(p => p.To - p.From) ?? 0;    
 
                 tags["VariantAssignmentPercentage"] = 100 - allocatedPercentage;
             }

Original file line number	Diff line number	Diff line change
`@@ -57,13 +57,7 @@ public static void HandleEvaluationEvent(EvaluationEvent evaluationEvent, ILogge`
`57`	`57`	`if (evaluationEvent.VariantAssignmentReason == VariantAssignmentReason.DefaultWhenEnabled)`
`58`	`58`	`{`
`59`	`59`	`// If the variant was assigned due to DefaultWhenEnabled, the percentage reflects the unallocated percentiles`
`60`		`- double allocatedPercentage = 0;`
`61`		`-`
`62`		`- if (evaluationEvent.FeatureDefinition.Allocation?.Percentile != null)`
`63`		`- {`
`64`		`- allocatedPercentage += evaluationEvent.FeatureDefinition.Allocation.Percentile`
`65`		`- .Sum(p => p.To - p.From);`
`66`		`- }`
	`60`	`+double allocatedPercentage = evaluationEvent.FeatureDefinition.Allocation?.Percentile?.Sum(p => p.To - p.From) ?? 0;`
`67`	`61`
`68`	`62`	`tags["VariantAssignmentPercentage"] = 100 - allocatedPercentage;`
`69`	`63`	`}`