fix: Ensure Reproducibility of ElasticNetEstimator#1374
Merged
thinkall merged 3 commits intoOct 29, 2024
Conversation
…nsure reproduciblity. Also included elasticnet in reproducibility tests
thinkall
approved these changes
Oct 29, 2024
Collaborator
thinkall
left a comment
thinkall
left a comment
There was a problem hiding this comment.
Nice! Thank you, @dannycg1996 .
This was referenced Apr 30, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElasticNetEstimator currently has no default random_state, so reproducing results is difficult. Described here. Taking the best model and re-fitting it to the same folds will garner different results, which isn't ideal.
Why are these changes needed?
Ensures that model results are reproducible.
Related issue number
Closes #1373
Checks